Q Light Controller Plus / Forum / [Read-Only] Development: Pull requests on github

Pull requests on github

Forum: [Read-Only] Development

Creator: Anonymous

Created: 2014-06-19

Updated: 2014-06-20

Anonymous - 2014-06-19

Hi,

I've oppened 2 pull requests on github 1 month ago, and I see no answer as of today.

You may not have the time to look at them, or maybe you don't receive github notifs ?
Should I open a thread on sourceforge for each pull request ? Do you have a preferred procedure ?

Just a simple question, I know you're very busy !

Regards.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Massimo Callegari - 2014-06-20
  
  Hello David,
  I did receive your PR and it's in my TODO list.
  Just haven't had the time to check it out.
  Please be patient but I think your change will be included in the next QLC+ version.
  
  Thanks
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jano Svitok - 2014-06-19

I'll answer in reverse order:

I suppose PR's are OK for code patches and translations. Fixture definitions have own forum section. You don't have to open thread on SF. I do get github notifications, and I suppose so does Massimo.

I have seen your PR's and even briefly tried to reproduce the problem with fixture deleting. Then I got to do something else and haven't returned back. Now I'm too busy with real life to do anything more.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2014-06-20

Thanks !

So, should I open a thread for discussing a feature/change request ?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: