qjson-devel Mailing List for QJson (Page 2)
Brought to you by:
flavio_castelli
You can subscribe to this list here.
| 2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
(5) |
Jul
(10) |
Aug
|
Sep
(4) |
Oct
(2) |
Nov
(7) |
Dec
(4) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2010 |
Jan
(5) |
Feb
(2) |
Mar
|
Apr
(4) |
May
(3) |
Jun
|
Jul
(4) |
Aug
(3) |
Sep
(5) |
Oct
(4) |
Nov
(5) |
Dec
(5) |
| 2011 |
Jan
(3) |
Feb
(11) |
Mar
(1) |
Apr
(8) |
May
(1) |
Jun
|
Jul
(3) |
Aug
(17) |
Sep
(7) |
Oct
(4) |
Nov
(2) |
Dec
(5) |
| 2012 |
Jan
(2) |
Feb
|
Mar
(5) |
Apr
(1) |
May
(3) |
Jun
(4) |
Jul
(2) |
Aug
(1) |
Sep
(1) |
Oct
(4) |
Nov
(26) |
Dec
|
| 2013 |
Jan
|
Feb
(2) |
Mar
(2) |
Apr
|
May
(5) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
(1) |
Aug
(1) |
Sep
(1) |
Oct
|
Nov
|
Dec
|
| 2015 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
(2) |
| 2017 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Flavio C. <fl...@ca...> - 2012-11-08 08:39:54
|
On 11/07/2012 10:49 PM, Ralf Jung wrote: > we just had some more discussion on this in IRC, and came to the > conclusion that there is no point in making an upstream release > specifically for this issue. Awesome! I'll delete the v0.7.2 branch then. > All we need is a guarantee that the next major release will do the cmake > stuff the same way master does it currently - then we can go ahead and > update our Debian-specific patches to do the same. I guarantee next release of qjson will ship with the cmake config files that are currently on master. Cheers Flavio |
|
From: Ralf J. <po...@ra...> - 2012-11-07 21:49:13
|
Hi again Flavio, we just had some more discussion on this in IRC, and came to the conclusion that there is no point in making an upstream release specifically for this issue. All we need is a guarantee that the next major release will do the cmake stuff the same way master does it currently - then we can go ahead and update our Debian-specific patches to do the same. Kind regards, Ralf |
|
From: Ralf J. <po...@ra...> - 2012-11-07 18:04:56
|
Hi again,
now we seem to have confused you entirely, sorry :(
Attached is a quick hacked-together patch. I compiled qjson, but I
didn't compile anything against it because it should be reviewed anyway
(and that would require me somehow crafting a debian package for this
version). It's essentially taken from the commits
69676d4564504c3f488b430e48666176e0e3d0c8 and
6abb5217acb18b59dc0f79e59475a4f4c483933a in master. Someone knowing
cmake better than me should have a look...
Lisandro suggested I should try to explain the problem again - okay, let
me try. I'll use KDE as example as that's where I saw it.
KDE uses find_package(QJSON) and then uses the variables
QJSON_INCLUDE_DIR and QJSON_LIBRARIES. That works all right with qjson
0.7.1. Then FindQJSON.cmake was dropped in libqjson master, and some
-config.cmake files were installed instead
(69676d4564504c3f488b430e48666176e0e3d0c8). That patch was backported to
Debian, but never released in qjson. And that patch breaks apps, because
KDE (somehow) still finds these files, but now the variables are called
qjson_INCLUDE_DIR and qjson_LIBRARIES (and they are case sensitive). For
that reason, 6abb5217acb18b59dc0f79e59475a4f4c483933a was committed in
qjson, but that one never arrived in Debian. Now KDE uses
"${QJSON_INCLUDE_DIR} ${qjson_INCLUDE_DIR}", which is of course a hack -
I added it to kde-workspace and just saw it's in kdepimlibs now as well.
Debian is nearing its next stable release, and IMHO it would be really
unfortunate to release it with a qqjson "cmake interace" (or however one
wants to call this collection of config files) incompatible with the
rest of the world. Therefore, we'd like to patch Debian to use the
interface the next major release of qjson will use, and we asked for
your assistance to be sure that this is indeed the case :)
I hope this clears things up. Thanks for your patience.
Ralf
|
|
From: Ralf J. <po...@ra...> - 2012-11-07 17:22:04
|
Hi, > Me neither, this whole situation puzzles me. I just applied your debian > patch. I hope that's enough for you, right? Sorry, there seems to be a misunderstanding here: The problem is that the Debian patch installs files which have variable names different from the ones in master. The patch is probably just wrong. A consequence is that KDE failed to build on Debian systems. I fixed KDE, but that's of course just a work-around. As I wrote in my other mail (we seem to parallelize a lot :D ), what we'd like to see is a 0.7.x release having a cmake interface compatible with your next major release. Or, alternatively, we may try to fix the mess within Debian. Kind regards, Ralf |
|
From: Ralf J. <po...@ra...> - 2012-11-07 17:17:51
|
Hi,
> My fault, I just applied your patch and I didn't try to build!
>
> I'll look into that.
The patch also adds two new files, which you probably forgot to git add.
However, these are exactly the files we do *not* want. I don't know who
wrote them, but they are incompatible with current QJson master.
Instead, what we'd prefer to see is for 0.7.2 to install files which
work like the ones from master. So that an application's cmake logic
which is written for one, also works with the other.
As far as I can see (but I just glimpsed over it), the files from master
are okay. Then, from master CMakeLists.txt, these lines seem to be
relevant at first glance (totally untested):
SET (CMAKECONFIG_INSTALL_DIR
"${LIB_INSTALL_DIR}/cmake/${CMAKE_PROJECT_NAME}" CACHE PATH "Directory
where to install QJSONConfig.cmake")
[snip]
# cmake-modules
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/QJSONConfig.cmake.in
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfig.cmake
@ONLY)
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/QJSONConfigVersion.cmake.in
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfigVersion.cmake
@ONLY)
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/QJSONConfig.cmake
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfigVersion.cmake
DESTINATION "${CMAKECONFIG_INSTALL_DIR}")
I do not know what the purpose of that uninstall file is, but master has
it as well, so maybe it should be added, too.
Kind regards,
Ralf
|
|
From: Flavio C. <fl...@ca...> - 2012-11-07 17:17:08
|
On 11/07/2012 06:07 PM, Ralf Jung wrote: > However, that branch doesn't actually build here... > CMake Error: File /home/r/Desktop/qjson/qjson-config.cmake.in does not > exist. > CMake Error at CMakeLists.txt:84 (CONFIGURE_FILE): > configure_file Problem configuring file I forgot to add these files. Do a git pull --force. They should appear. Building works now and the unit tests are passing. > The filenames are also not the same as in master. Not sure if that is a > problem. Me neither, this whole situation puzzles me. I just applied your debian patch. I hope that's enough for you, right? Flavio |
|
From: Flavio C. <fl...@ca...> - 2012-11-07 17:11:24
|
On 11/07/2012 06:07 PM, Ralf Jung wrote: > However, that branch doesn't actually build here... > CMake Error: File /home/r/Desktop/qjson/qjson-config.cmake.in does not > exist. > CMake Error at CMakeLists.txt:84 (CONFIGURE_FILE): > configure_file Problem configuring file > > The filenames are also not the same as in master. Not sure if that is a > problem. My fault, I just applied your patch and I didn't try to build! I'll look into that. Flavio |
|
From: Ralf J. <po...@ra...> - 2012-11-07 17:07:24
|
Hi, > I'm a bit skeptical about overwriting the old 0.7.1 release, that's why > I chose this approach. Sure, changing a release without changing the version number is a no-go. We could have done this in Debian, increasing the Debian revision so we'd be at version 0.7.1-7 (the current one is 0.7.1-6). However, that branch doesn't actually build here... CMake Error: File /home/r/Desktop/qjson/qjson-config.cmake.in does not exist. CMake Error at CMakeLists.txt:84 (CONFIGURE_FILE): configure_file Problem configuring file The filenames are also not the same as in master. Not sure if that is a problem. Kind regards, Ralf |
|
From: Flavio C. <fl...@ca...> - 2012-11-07 16:59:13
|
On 11/07/2012 05:26 PM, Lisandro Damián Nicanor Pérez Meyer wrote: > Here it is: > > [0] <http://patch- > tracker.debian.org/patch/series/view/qjson/0.7.1-6/install_cmake_config.patch> Great, I branched version 0.7.1, applied the patch and increased the patch level. The code is inside of this branch: https://github.com/flavio/qjson/tree/v0.7.2 If the code looks fine for you I can tag this version as 0.7.2. I'm a bit skeptical about overwriting the old 0.7.1 release, that's why I chose this approach. BTW: yes, the code is on github. As part of the next major release I'm going to migrate the code from gitorious to github. Right now I'm keeping the two repositories in sync (except for this v0.7.2 branch). Cheers Flavio |
|
From: Lisandro D. N. P. M. <per...@gm...> - 2012-11-07 16:29:11
|
On Wed 07 Nov 2012 13:23:11 Flavio Castelli escribió: > On 11/07/2012 04:51 PM, Ralf Jung wrote: > > Or did you mean, a 0.7.2 where the only difference to 0.7.1 is the cmake > > file? > > Yes. that's what I mean. > > > I am busy this weekend, but I should be able to find some time now and > > then to help testing. > > That would be great. > > BTW my plan it to release a major version of QJson ASAP (I'm sick of > this situation). I could release v0.7.2 even after the new major release > is out. Well, seems we were both writing at the same time :-) Thanks a lot for your support Flavio! -- I wish to be cremated. One tenth of my ashes shall be given to my agent, as written in our contract. -- Groucho Marx Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ |
|
From: Lisandro D. N. P. M. <per...@gm...> - 2012-11-07 16:27:15
|
On Wed 07 Nov 2012 12:45:44 Flavio Castelli escribió: > On 11/06/2012 09:52 PM, Lisandro Damián Nicanor Pérez Meyer wrote: > > - Do not apply the aforementioned patch and reopen > > http://bugs.debian.org/628981 > > I cannot find the patch in question on the page. Here it is: [0] <http://patch- tracker.debian.org/patch/series/view/qjson/0.7.1-6/install_cmake_config.patch> > > - Somebody writes a patch for the current stable release (0.7.1) to > > define the same caps in the symbols (sorry, I can't offer myself to do > > this because of lack of time) > > You would basically want a 0.7.2 version which brings only the cmake > config files from master. Am I right? It doesn't needs to be a new upstream release, it can also be a simple patch to 0.7.1. Anyway, both ways will work. Please take into account that, wrt Debian's release cycle, it's too late for a new upstream release with all the changes in the current master of qjson. So, let me try to rephrase this just in case I'm not clear enough (english is not my native languague :-) ): the idea is to provide users with the correct CMake symbols that will be used in qjson. As far as I understand, we (Debian) are shipping some symbols [0] which are: qjson_FOO And should be: QJSON_FOO This is mostly to let developers use 0.7.1 without having to change that in the next version of the package. Please, do not heasitate to write if you need more info/anything else. Kinds regards, Lisandro. -- Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ |
|
From: Flavio C. <fl...@ca...> - 2012-11-07 16:24:14
|
On 11/07/2012 04:51 PM, Ralf Jung wrote: > Or did you mean, a 0.7.2 where the only difference to 0.7.1 is the cmake > file? Yes. that's what I mean. > I am busy this weekend, but I should be able to find some time now and > then to help testing. That would be great. BTW my plan it to release a major version of QJson ASAP (I'm sick of this situation). I could release v0.7.2 even after the new major release is out. Flavio |
|
From: Ralf J. <po...@ra...> - 2012-11-07 16:07:16
|
Hi, > You would basically want a 0.7.2 version which brings only the cmake > config files from master. Am I right? No, a 0.7.1 version with the cmake config file from master. Or did you mean, a 0.7.2 where the only difference to 0.7.1 is the cmake file? Yeah, that, too - except that I don't know the Debian details here. Lisandro, is the pure fact that the upstream version number changed an issue to get a freeze unblock? Also, do we have to worry about reverse dependencies relying on the current, broken file? Those can obviously be in Debian only. I am busy this weekend, but I should be able to find some time now and then to help testing. Kind regards, Ralf |
|
From: Flavio C. <fl...@ca...> - 2012-11-07 15:46:43
|
On 11/06/2012 09:52 PM, Lisandro Damián Nicanor Pérez Meyer wrote: > - Do not apply the aforementioned patch and reopen > http://bugs.debian.org/628981 I cannot find the patch in question on the page. > - Somebody writes a patch for the current stable release (0.7.1) to define the > same caps in the symbols (sorry, I can't offer myself to do this because of > lack of time) You would basically want a 0.7.2 version which brings only the cmake config files from master. Am I right? Cheers Flavio |
|
From: Flavio C. <fl...@ca...> - 2012-11-07 15:45:04
|
On 11/05/2012 08:16 PM, Lisandro Damián Nicanor Pérez Meyer wrote: >> Now, before we start fixing Debian or patch KDE (which is bitten by >> this), I'd appreciate an official statement from the developers how the >> cmake config file installed by the next release will look like. I don't >> expect any changes, but since you didn't yet commit to a scheme by doing >> a release, any clarification would help. I'm going to release a new version of qjson in the next days. The new version will use cmake config files available on master right now. Cheers Flavio |
|
From: Lisandro D. N. P. M. <per...@gm...> - 2012-11-06 21:11:24
|
On Tue 06 Nov 2012 17:52:39 Lisandro Damián Nicanor Pérez Meyer escribió: [snip] > The options I see are: > > - Do not apply the aforementioned patch and reopen > http://bugs.debian.org/628981 > > - Somebody writes a patch for the current stable release (0.7.1) to define > the same caps in the symbols (sorry, I can't offer myself to do this > because of lack of time) > > - Simply keep shipping the package as it is. Sorry, I forgot to mention: feel free to propose any other ideas :-) -- http://www.phdcomics.com/comics/archive.php?comicid=56 Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ |
|
From: Lisandro D. N. P. M. <per...@gm...> - 2012-11-06 21:11:24
|
On Mon 05 Nov 2012 16:16:17 Lisandro Damián Nicanor Pérez Meyer escribió: [snip] > I'm the maintainer of QJson in Debian. I would really appreciate if you > could comment on this. OK, I have reviewed the changes in the Debian packaging. The patch description is: Description: install a CMake config file. This patch enables the creation of CMake's config files for QJson. It has been taken from upstream's GIT, taking the difference between tag 0.7.1 and master's commit 83c1323 of CMakeLists.txt. It also adds qjson-config-version.cmake.in and qjson-config.cmake.in, taken from the same commit mentioned above. I have also reviewed the current master branch and it contains too much changes for asking for an unblock bug during a freeze (our current state) in Debian. The options I see are: - Do not apply the aforementioned patch and reopen http://bugs.debian.org/628981 - Somebody writes a patch for the current stable release (0.7.1) to define the same caps in the symbols (sorry, I can't offer myself to do this because of lack of time) - Simply keep shipping the package as it is. Kinds regards, Lisandro. -- ...man had always assumed that he was more intelligent than dolphins because he had achieved so much -- the wheel, New York, wars and so on -- whilst all the dolphins had ever done was muck about in the water having a good time. But conversely, the dolphins had always believed that they were far more intelligent than man -- for precisely the same reasons. Douglas Adams, "The hitchhikers' guide to the galaxy" Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ |
|
From: Lisandro D. N. P. M. <lis...@de...> - 2012-11-05 19:36:28
|
Hi! On Sun 16 Sep 2012 16:23:50 Ralf Jung escribió: > Hi jqson developers, > > what are your plans regarding the cmake configuration file which is > installed by your current git master version (as I'm told), but not by > the latest stable release? To be precise, will the variables be called > exactly the way they are now, in their unreleased state? > The reason I am asking is that the Debian package installs the config > files from the last stable release (which presumably were for internal > use only), where the variables are named in lower-case > (qjson_INCLUDE_DIR), while your file uses upper-case names, which is > also (as far as I know) common for cmake: QJSON_INCLUDE_DIR. This is > tracked in the Debian bugtracker at > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687537 > > Now, before we start fixing Debian or patch KDE (which is bitten by > this), I'd appreciate an official statement from the developers how the > cmake config file installed by the next release will look like. I don't > expect any changes, but since you didn't yet commit to a scheme by doing > a release, any clarification would help. I'm the maintainer of QJson in Debian. I would really appreciate if you could comment on this. > PS: Please keep me in CC in replies, I am not subscribed to the list Same goes for me :-) Kinds regards, Lisandro. -- I wish to be cremated. One tenth of my ashes shall be given to my agent, as written in our contract. -- Groucho Marx Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ |
|
From: Flavio C. <fl...@ca...> - 2012-10-30 16:35:19
|
On 07/19/2012 02:50 AM, Michael Carpenter wrote: > I would expect this kind of output: > "[[ "0", "1", "2", "3", "4"], ["0", "1", "2", "3", "4"] ]" > > However, I get this output: > "[ "0", "1", "2", "3", "4", "0", "1", "2", "3", "4" ]" > > Is this intentional, or a bug? No that's a bug. I did some tests and it seems the issue is inside of QVariant#toList(). I'm building latest version of Qt from git, try to reproduce (maybe fix the issue). I'll surely file a bug upstream. Cheers Flavio |
|
From: Flavio C. <fl...@ca...> - 2012-10-30 14:56:02
|
On 10/28/2012 11:12 AM, Venkatraman V wrote: > I can't find the .pro file for Windows compilation in the 0.7.1 version > (or 0.7.0 ). Can someone help me with that. The .pro files are currenlty only inside of master. But to be honest, I plan to remove them since I'm sick of managing two different build system. I highly recommend you to build qjson using cmake. Cheers Flavio |
|
From: Flavio C. <fl...@ca...> - 2012-10-30 14:53:18
|
On 06/21/2012 11:33 AM, 蔡火胜 wrote: > When I set the type of one property to be quint16 , I can't get the > object serialized . Is it intended ? No, that was a bug. I've just fixed it on master. The fix will be part of the next release of qjson (ETA the end of this week). Cheers Flavio |
|
From: Venkatraman V <ven...@gm...> - 2012-10-28 10:12:36
|
Hello, I can't find the .pro file for Windows compilation in the 0.7.1 version (or 0.7.0 ). Can someone help me with that. Regards Venkat |
|
From: Ralf J. <po...@ra...> - 2012-09-16 19:41:26
|
Hi jqson developers, what are your plans regarding the cmake configuration file which is installed by your current git master version (as I'm told), but not by the latest stable release? To be precise, will the variables be called exactly the way they are now, in their unreleased state? The reason I am asking is that the Debian package installs the config files from the last stable release (which presumably were for internal use only), where the variables are named in lower-case (qjson_INCLUDE_DIR), while your file uses upper-case names, which is also (as far as I know) common for cmake: QJSON_INCLUDE_DIR. This is tracked in the Debian bugtracker at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687537 Now, before we start fixing Debian or patch KDE (which is bitten by this), I'd appreciate an official statement from the developers how the cmake config file installed by the next release will look like. I don't expect any changes, but since you didn't yet commit to a scheme by doing a release, any clarification would help. Thanks a lot, Ralf PS: Please keep me in CC in replies, I am not subscribed to the list |
|
From: shancat <sha...@gm...> - 2012-08-06 13:02:29
|
Hey, I've seen other projects ( https://github.com/pypt/fervor/blob/master/Fervor.pri) that have a .pri file--otherwise known as a project include file. Syntactically it's no different to a .pro file. From your main .pro file you include the .pri file and that's all you need to do to get it to compile in your current project. I was wondering in qjson's .pro file was able to just be included or if modifications would be needed? |
|
From: Michael C. <mal...@gm...> - 2012-07-19 00:50:36
|
Given the following code:
QVariantList l1;
QVariantList l2;
QVariantList l3;
l2.append("0");
l2.append("1");
l2.append("2");
l2.append("3");
l2.append("4");
l3.append("0");
l3.append("1");
l3.append("2");
l3.append("3");
l3.append("4");
l1.append(l2);
l1.append(l3);
QJson::Serializer ser;
qDebug() << ser.serialize(l1);
I would expect this kind of output:
"[[ "0", "1", "2", "3", "4"], ["0", "1", "2", "3", "4"] ]"
However, I get this output:
"[ "0", "1", "2", "3", "4", "0", "1", "2", "3", "4" ]"
Is this intentional, or a bug?
|