qdbm-users

[qdbm-users] dpopen

[George N. <ge...@ne...>]

Hi All,

I am a new user of qdbm,  I think there may be a bug in depot.c:255,
dpopen()   (from v.1.8.77)

  if(!(omode & DP_ONOLCK) &&
     ((dpbigendian() ? memcmp(hbuf, DP_MAGICNUMB, strlen(DP_MAGICNUMB)) != 0 :
       memcmp(hbuf, DP_MAGICNUML, strlen(DP_MAGICNUML)) != 0) ||
      *((int *)(hbuf + DP_FSIZOFF)) != fsiz)){
    close(fd);
    dpecodeset(DP_EBROKEN, __FILE__, __LINE__);
    return NULL;
  }

It seems to me these checks should -not- be qualified with  !(omode &
DP_ONOLCK)

Is this a bug or intended?

Thanks,
George.

Re: [qdbm-users] dpopen

[Mikio H. <mi...@us...>]

Hi,

> It seems to me these checks should -not- be qualified with  !(omode &
> DP_ONOLCK)
> 
> Is this a bug or intended?

It is intended behaviour.
When DP_ONOLCK is specified, validation to the database format is not
assured.  So, check is omitted.

Regards.

// Mikio Hirabayashi

Re: [qdbm-users] dpopen

[George N. <ge...@ne...>]

Mikio,

On Sun, Oct 5, 2008 at 4:16 AM, Mikio Hirabayashi
<mi...@us...> wrote:
> Hi,
>
>> It seems to me these checks should -not- be qualified with  !(omode &
>> DP_ONOLCK)
>>
>> Is this a bug or intended?
>
> It is intended behaviour.
> When DP_ONOLCK is specified, validation to the database format is not
> assured.  So, check is omitted.

Sometimes an invalid depot file will be passed to dpopen(); and it
doesn't fail.  I will "mode & ~DP_ONOLCK" in my wrapper function to
force the header check for now.

Is it possible to have the dpopen() documentation mention DP_ONOLCK
turns off depot header and file size checks, it currently only
mentions that it opens a database without locking.

TIA,
George.