Re: [PyX-devel] valign.middle

[Joerg L. <jo...@us...>]

Hi André,

On 28.12.03, Andre Wobst wrote:
<snip>
> I've now restored the valign.middle (the old implementation was ok)
> using the new attribute system. Jörg: please take a look at the merge
> method when combining exclusiveattr and sortbeforeattr (I've corrected
> it style.linewidth as well). The attribute should not be added twice.
> Thus the code looks like:
> 
>     def merge(self, attrs):
>         return attr.sortbeforeattr.merge(self, attr.exclusiveattr.merge(self, attrs)[:-1])

Hmm, this assumes implicitly that attr.exclusiveattr.merge returns self as
last element in the list -- which is currently the case.

> We may add a combined exclusive and sort attr because we do have this
> merge code several times in the attributes already ... what do you
> think?

Taking into account the problem mentioned above, I think this is a
good idea. So what about a sortbeforeexclusiveattr class? If there
are no objections, I'll go ahead and implement this.

        Jörg