Re: [PyX-devel] valign.middle

[Andre W. <wo...@us...>]

Hi Magnus,

On 27.12.03, Magnus Lie Hetland wrote:
> > What concerns the valign attribute, I think that André plans to
> > change something, but I'm not sure about that...
> 
> Right -- I'll just wait and see, then :)

Yes, valign.middle was removed by accident as noted in CHANGES and the
source. I likely happened when I moved the code to the new attribute
system and I couldn't do much more then writing a note because I was
traveling when I noticed it (I don't have access to CVS when I'm on
the train, where I did most of the develoment during the last weeks --
well, I didn't did much develoment during the last weeks at all, but
I'll hopefully get more time for the development in near future).

I've now restored the valign.middle (the old implementation was ok)
using the new attribute system. Jörg: please take a look at the merge
method when combining exclusiveattr and sortbeforeattr (I've corrected
it style.linewidth as well). The attribute should not be added twice.
Thus the code looks like:

    def merge(self, attrs):
        return attr.sortbeforeattr.merge(self, attr.exclusiveattr.merge(self, attrs)[:-1])

We may add a combined exclusive and sort attr because we do have this
merge code several times in the attributes already ... what do you
think?


André

-- 
by  _ _      _    Dr. André Wobst
   / \ \    / )   wo...@us..., http://www.wobsta.de/
  / _ \ \/\/ /    PyX - High quality PostScript figures with Python & TeX
 (_/ \_)_/\_/           visit http://pyx.sourceforge.net/