Menu ▾ ▴

#497 Working with interwikis on subpage

open
xqt
None
6
2011-04-21
2010-12-29
DixonD
No

I think I implemented my feature request with ID: 3146291
Please, review carefully my code - to be honest I don't have really much experience with Python.
And few moments:
1) When we adding/fixing interwikis on subpage, I think we should remove interwikis in template itself if any
2) It seems that logic of determing whether this page has subpages, getting interwikis also from included subpages etc should be decoupled from interwiki.py and moved to wikipedia.py
3) Not really related but.. cosmetic_changes.py removes interwikis from subpage.

Discussion

  • DixonD

    DixonD - 2010-12-29
    • priority: 5 --> 6
     

  • DixonD

    DixonD - 2010-12-30

    Uploaded new patch with some fixes.

     

  • DixonD

    DixonD - 2010-12-31
     
    interwiki_subpages.patch

  • DixonD

    DixonD - 2011-03-30

    Any news?

     

  • DixonD

    DixonD - 2011-04-21
    • assigned_to: nobody --> xqt
     

  • Merlijn S. van Deen

    Merlijn S. van Deen - 2012-03-21

    Sorry for the very... slow response. The problem is that interwiki.py is complicated (as you have noticed), and it's a somewhat complicated patch. To be honest: I'm not even sure how much interwiki.py does in terms of templates, subpages... and as such I'm scared as hell to even touch the script, considering it sort of works at the moment.

     

  • Merlijn S. van Deen

    Merlijn S. van Deen - 2012-03-21

    Housekeeper's note: the patch does not apply cleanly to r10035

     

Log in to post a comment.