Menu

broken code since R357

Help
Tonka
2014-10-07
2014-10-09
  • Tonka

    Tonka - 2014-10-07

    Hy@everybody,

    i've downloaded PythonQt yesterday. I've tried to build it with Python 3.4 (offical windows installer) (on windows 7 x64 and Visual Studio 2010 SP1 x64). I had some troubles to build, but i could figure out the problem(s).

    My build:
    - Open PythonQt.pro file with QtCreator (all environment varibales are set and Python.prf is tweaked from 26 to 34)
    - set config from Debug to Release (because the offical windows build of python does not contains the debug files)
    - Build Project

    Tested Qt-Versions:
    - 4.7.3
    - 4.8.5
    - 4.8.6
    - 5.3

    First problem:

    QtCreator (and qmake itself) always throw a warning in the console "uitools is an unknown qt-module" (this is not the original message). The problems with that is that qmake does not produce 100% correct visual studio projects (because it is missing uitools).
    The uitools definition is set in the pro files, but in the wrong place for Qt 4.x build (Qt 5.x seems to be fine). At the moment is is defined like following:

    QT += uitools

    It seems that Qt4.x didn't like that, uitools has to be defined in the CONFIG variable like...

    CONFIG += uitools

    I didn't remove uitools from the QT varibale (so it will continue throwing warnings), because it is needed in Qt 5.x (a switch would be a nicer solution to avoid throwing this warning).

    Second problem:
    The prebuild generated_cpp files for 47 and 48 seems to be broken. I always get a linking error for PythonQtWrapper_QClipboard::event(.....). The solution is to uncomment or remove the line. That problem was introduced with Revision 357: the event-method was removed from the cpp (com_trolltech_qt_gui1.h and com_trolltech_qt_gui1.cpp) an so the linker could not find that method (because it is not there). If i created the cpp-files with the generator there is no PythonQtWrapper_QClipboard class and so the problem is also fixed!

    Only a little commmet to the repo itself:
    I would be nice/easier if the repo would be on github or any other git-based source-managament platform because i would instead sending you a pull-request to fix that problems => so the repo would be easier to maintain.

    I hope this project will be maintained for a long time because it is absolutely awesome idea/work :-) .

    Greetings
    Tonka

     
  • Florian Link

    Florian Link - 2014-10-07

    Thanks for reporting, I did not do enough testing for 4.7/4.8, because I was focused on qt 5.... I will incorporate your fixes tomorrow.

     
  • Florian Link

    Florian Link - 2014-10-08

    I fixed th uitools and the QClipboard issues on the trunk.

     
  • Tonka

    Tonka - 2014-10-09

    I fixed th uitools and the QClipboard issues on the trunk.
    Oh, good to hear :-)

    Thanks for reporting, I did not do enough testing for 4.7/4.8, because I was focused on qt 5
    No problem, i will make the tests for Qt 4.x ;-)

    Greetings

     

Log in to post a comment.