Re: [Pythoncad-developer] Some small points

[Matteo B. <mat...@bo...>]

Hi Gertwin,

> 1) In the repository there is a gtkError.py and a gtkerror.py
> (http://pythoncad.git.sourceforge.net/git/gitweb.cgi?p=pythoncad/pythoncad;a=tree;f=PythonCAD/Interface/Gtk;h=f0c84bcb2e94d8ff2a1229d922f96399bbb2cc30;hb=R38).
> On windows this can give problems, maybe it is better to give all the
> source files lower case filenames.
gtkError.py could be deleted it's an error i will do it ..
of course the file have to be all in lowercase to avoid error.

> 
> 2) Angles are internally measured in degrees, I think that this should
> be radians.
> All the math/cairo functions take radians as input parameters,
> maintaining degrees as internal values causes constant calculation
> from degrees to radians.
> If we maintain radians as the internal value only in the user
> interface a translation has to be done.

ok for me it's ok 
let the user use the degrees, internally we will convert all in radiants
and use the radiants as stadard angle mesure.

> 3) Sometimes points are defined as a tuple of two doubles and
> sometimes as a Point (object).
> This also leads to unnecessary conversions between the two.
> For me I think alway use the Point object for point is the most
> convenient.
> The point object contains functions for distance, equality etc. which
> are handy.

I notice this problem the first time i sow the pythoncad code...
using Point it's right.

but we need to modifie a lot of code.. and somtimes the touple is very
light..
may be is better to think of it before convert the touple in point.
What do you think?

Regards,
Matteo