On Sun, Jan 10, 2010 at 10:00 PM, Yuri Takhteyev <qar...@gm...> wrote:
>> Looks to me like url_manager is some third party module for someone's
>> blog app. With a quick glance, it appears it's just building the path
>> for each image and the thumbnail path.
>
> That someone would be me.
>
> I don't remember for sure, but this might have been the original
> Markdown extension, which I checked in (probably ~2006) as an example.
> I.e., you could never use it directly since it was hooked into my blog
> code (which I released at some point too, but it's not worth looking
> for), but it would give you an example of how to write an extension. I
> am pretty sure that for a while there were just two extensions - this
> one and footnotes.
>
> Now that we have no shortage of examples, perhaps we should delete it.
> Or, someone could fix it.
>
Ah, well that explains things - including why there has never been any
tests for it.
Given the proliferation of javascript libraries (i.e.: JQuery plugins)
that can create nice galleries given a list of photos, I'm not so sure
this extension is of much value. Although, being that I never used it,
I don't know what its output looked like. Perhaps a simple extension
that listed all photos in a given directory for use by these modern
gallery libs would be sufficient.
While automated dir walking is nice, I think I'd prefer to just add
the images manually to a markdown document. That certainly avoids the
issues involved in working out paths and such in code. And given that
I recently added the ability to have markdown text inside any
arbitrary raw html block (via markdown=1 attribute like php does), you
could even wrap your list in an appropriate block with a class or id
set for your javascript to work off of. In addition this wouldn't tie
you to any specific js library. Write you own raw html to fit the lib
your using. Much better that trying to write an extension that works
with many libs and their varying APIs.
I guess this is a long way around saying I'm inclined to simply remove
it. Obviously, it doesn't work for anyone so no one should miss it.
However, if someone else wanted to fix it, I wouldn't be against
merging their changes in either.
--
----
\X/ /-\ `/ |_ /-\ |\|
Waylan Limberg
|
