python-markdown-discuss

[Python-markdown-discuss] MarkdownException?

[David W. <wo...@cs...>]

Is there any reason nothing explicitly raises exceptions?  I've uses  
sys.exit() in load_extension, which in retrospect is probably the  
wrong thing to do (if Markdown is being used as a module)... But it  
also didn't feel right to either return None or create an exception  
class and raise that.

Re: [Python-markdown-discuss] MarkdownException?

[Yuri T. <qar...@gm...>]

> Is there any reason nothing explicitly raises exceptions?  I've uses
>  sys.exit() in load_extension, which in retrospect is probably the
>  wrong thing to do (if Markdown is being used as a module)... But it
>  also didn't feel right to either return None or create an exception
>  class and raise that.

Yes, there is a reason: procrastination.

Yes, sys.exit(1) is not appropriate here nor is returning None. (And I
should have caught this!)

I think the thing to do here is to raise an exception, the only
question is what to call it.  MarkdownException would be reasonable,
though perhaps something more specific would make more sense?

Greg's code review
(http://www.third-bit.com/pages/reviewing-markdown.html) noted a few
other cases where we should do what he calls "if/then/else/oops"
instead of "if/then/else".  If we fix those, then this would give us
more opportunities to use MarkdownException.

 - yuri

Re: [Python-markdown-discuss] MarkdownException?

[David W. <wo...@cs...>]

On 26-Feb-08, at 3:39 AM, Yuri Takhteyev wrote:
> I think the thing to do here is to raise an exception, the only
> question is what to call it.  MarkdownException would be reasonable,
> though perhaps something more specific would make more sense?
I'd say MarkdownException is pretty clear :)

Then, to make the command-line people happy, the "if __name__ ==  
"__main__":..." code could be wrapped in a "try: ... except  
MarkdownException:  ... except Exception: ..." so users don't get  
tracebacks on MarkdownExceptions.

Re: [Python-markdown-discuss] MarkdownException?

[David W. <wo...@cs...>]

Ok, I've attached a patch which adds a MarkdownException class and  
then raises it at a few opportune moments.

I've also added a bit of checking on the -s argument.

What do you think?

On 26-Feb-08, at 12:04 PM, David Wolever wrote:

> On 26-Feb-08, at 3:39 AM, Yuri Takhteyev wrote:
>> I think the thing to do here is to raise an exception, the only
>> question is what to call it.  MarkdownException would be reasonable,
>> though perhaps something more specific would make more sense?
> I'd say MarkdownException is pretty clear :)
>
> Then, to make the command-line people happy, the "if __name__ ==
> "__main__":..." code could be wrapped in a "try: ... except
> MarkdownException:  ... except Exception: ..." so users don't get
> tracebacks on MarkdownExceptions.