Waylan Limberg wrote:
> Just an FYI to everyone. I've come to realize more than ever today
> that just because the tests included in the repo are passing does not
> mean *anything*. If you look at the numerous commits I've made today,
> most are changes to the tests themselves. I've spent hours fixing bad
> tests and only minutes on actual bugs in the code.
>
> It seems that when the tests were altered to fit the output of
> ElemenTree, a large number of new bugs have been introduced into the
> tests. So while it looks like everything is ok - I've found a few
> glaring blunders. The only way to catch them is to either do your own
> testing outside the provided tests and fix the bugs - then run the
> tests and fix all the tests that fail, or to review each and every
> test by hand and try to spot problems.
>
Hmm, tests modification was done in that way:
I changed output of NanoDOM, without any changes in core, then I ran
through all tests and wrote results to separate files.
So, I think problems concerning switching to ElementTree could only
exist in TextPostprocessors. We have only 2 TextPostprocessors, I don't
think that there are a lot of problems concerning this issue.
Also, before porting to ElementTree and modify tests, I found some
incorrect tests too, most of them concerned inline patterns.
And now I realize, why changing of NanoDOM output changed this output:
<hr />, to <p><hr /></p> :) I even created branch called stripped-dom,
to find out what the problem is, but later I decided to I add
Markdown._processHR function.
|
