From: Yuri T. <qar...@gm...> - 2007-10-05 20:10:31
|
Sorry for not responding earlier. It's been a hectic month. (Or, should I say a hectic year...) > For as long as I can remember the following comment has been in the > CorePatterns class: > > """This class is scheduled for removal as part of a refactoring effort.""" > > My question is; what would that refactor entail? Is there any help I > can provide? I believe I put this comment there when I was refactoring Markdown to put much of processing into the instances of the Pattern class (SimpleTextPatter, BacktickPattern, etc.) After I did this there were some regular expressions that were left over. I must have had some plan on what to do with them eventually, but if I did, I no longer remember what it was. So, "scheduled for removal" is too strong of a word. It would be better to say: it would be nice to get rid of this collection of "leftover" patterns I figure out how. > I'm not posting this to complain. I'd just like to see that refactor > move forward if that's still the plan. If I can help, even better. The > problem is, I don't know what the plan is, so its a little difficult > to help. At the same time I realize this is complex stuff. There is no plan. If you can help with further refactoring, I would much appreciate it. Email me your sourceforge ID and I will add you to the project. In particular, your patch looks good. If it doesn't break any tests, let's commit it. Thanks for the help! - yuri -- http://www.freewisdom.org/ |