From: Waylan L. <wa...@gm...> - 2011-12-15 03:19:02
|
Alex, I just reverted the rawhtmlblock preprocessor and it is definitely faster on docs with lots of html. I pushed a commit to github on the slowhtml [1] branch. See the diff here [2]. I should note that a number of tests are failing and not just the test for the new support of attr in raw html. One test is even raising an exception. Every change to that file since the original commit needs to be reviewed and possibly reimplemented before this code could be considered stable. That said, I'm not intending on committing this to master anyway. We don't want to lose support for attributes in raw html. Perhaps a more efficient solution than the current (long) regex would be the way forward. Not something I have time for right now. At least we know what is causing the slowdown. [1]: https://github.com/waylan/Python-Markdown/tree/slowhtml [2]: https://github.com/waylan/Python-Markdown/commit/790aeb56053940f299d600d8d364fc3fc8151085 On Wed, Dec 14, 2011 at 5:48 PM, Alexandre Leray <new...@al...> wrote: > Thanks Waylan for looking into this, much appreciate. > > waiting to hear from you, > > Thanks, > > Alex > > > On 14/12/2011 22:03, Waylan Limberg wrote: >> >> No I hadn't. My unscientific observations were that 2.1.0 might be >> slightly faster. However, I don't do much raw html myself. In any >> event, my first guess would be that the cause is the changes made here >> [1] and here [2], which addressed this issue [3]. I'll try confirming >> that later tonight. >> >> I suggest reporting it on Github [4] so we don't forget about it. >> >> [1]: >> https://github.com/waylan/Python-Markdown/commit/fc3020c68575042a1ff5426ddd94bc4be65bf77d >> [2]: >> https://github.com/waylan/Python-Markdown/commit/c2d50b46b536a440b6d73c6bf309bdaf03b90abb >> [3]: http://www.freewisdom.org/projects/python-markdown/Tickets/000048 >> [4]: https://github.com/waylan/Python-Markdown/issues/new > > -- ---- \X/ /-\ `/ |_ /-\ |\| Waylan Limberg |