Re: [Python-markdown-discuss] Changes to make it easier to bundle markdown

[Waylan L. <wa...@gm...>]

On Mon, Jul 5, 2010 at 2:43 PM, Toshio Kuratomi <a.b...@gm...> wrote:
[snip]
> I have a patch here that seems to work:
> http://gitorious.org/python-markdown/toshios-mainline/commit/b50560edc707241b236f9d6c3f33edcf09d7cf33
>

Thanks for the feedback.  We are always looking for ways to make
python-markdown better.

I'm not so sure about your move of things to misc.  Personally, I
wonder why not "util", but that's just bike shedding.

What really concerns me is that there are a number of third party
extensions which import these things.  Many of these extensions have
never been published publicly and we have promised that they will
continue to work.  So my question is, will these changes only require
a small adjustment in an import line, or more work.  And if they do
require just the change in the import line, will the extension only be
able to work on either one version of markdown or the other?

In fact, a number of the things you've moved to misc, I had intended
to most to a util file.  But I never got to it before the release of
2.0 and now I've considered us stuck with things the way they are for
the above reasons.  However, if you can convince me that that will not
be a problem, then I will gladly merge such a change.

However, regarding the global variables.  Most of those do not need to
be global variables, but properties on an instance of the Markdown
class.  In fact, this will also make it easier for users and/or
extensions to override with their own settings. I've been meaning to
do this.  However, the few that do need to be global variables, I
don't see why they can't stay where they are.

Personally, I find it strange that you would need to ship markdown
inside your package.  Why can't markdown be a separate library in it's
own namespace? That way users can upgrade to newer versions without
waiting for you to. Sure, I realize you may be offering wrappers and
want to offer a compatibility guarantee, but I'd personally prefer the
option of stepping outside that if I wanted. But maybe that's just me.

-- 
----
\X/ /-\ `/ |_ /-\ |\|
Waylan Limberg