From: Waylan L. <wa...@gm...> - 2009-01-28 03:52:48
|
Ok, I've attached my changes to Eric's patch. "html4_all.diff" includes everything. Apply it against a clean latest copy of python markdown from the mainline repo on Gitorious. "html4.diff" contains only my changes to Eric's work. Use this if you have already applied Eric's patches. All tests pass for Python 2.3, 2.4, 2.5 & 2.6. I did not bother running 2to3 yet. One more question: Eric put the "output_format" keyword in the "convert" & "convertFromFile" methods, not the "__init__" method of the Markdown class. Do we want to set the format for the class (in "__init__") or per call to "convert". The current implementation allows easy output of both formats. However, I wonder if the more common usage is to always require a single format for multiple documents. If so, then it should be set on "__init__" instead. Any input? If/when we receive blessing from Fredrik, I'll commit this pending any suggested changes. -- ---- \X/ /-\ `/ |_ /-\ |\| Waylan Limberg |