From: Eric A. <gi...@gm...> - 2009-01-27 18:32:50
|
On Jan 28, 2009, at 2:02 AM, Waylan Limberg wrote: > On Tue, Jan 27, 2009 at 11:34 AM, Eric Abrahamsen <gi...@gm...> > wrote: >> >> >> Well getting patches out has been almost as frustrating as creating >> an >> online branch, but these four files ought to do it... >> >> Eric >> > > Just did a quick read through your patches. Looks good. I'll apply > them when I get a chance with proper credit etc. > > One thing I didn't see is the option added to the commandline. But I > can do that if you don't get to it first. I'll try to get to this soon, but I'm hitting the road for a day or two and might not get to it right away... > Now a question to the list: Does anyone have a preference as to what > we call the option? > > Eric added the keyword "method". So ``markdown(text, method="html")`` > for example. It doesn't really matter to me, but it occurs to me that > the term "method" isn't exactly self documenting. However, it does > seem better than anything else I can think of. I used "method" simply because that's what was in the ElementTree alpha. I suppose "format" would be just as accurate, if not more so. > Oh, and should the options be "html" & "xml" or "html" & "xhtml"? For the record, I'm in favor of html vs xhtml, rather than xml vs html, though I don't think it matters all that much. I'm quite willing to do the tweaking when the time comes, if necessary. You mentioned licenses in an earlier email -- most of the additions here are lifted straight out of Fredrik Lundh's most recent 1.3 alpha, do you think we should check with him? I spent more time trying to make git work than I did patching markdown! But it seems to be the wave of the future, so I guess I'll buckle down and study. Eric > > -- > ---- > \X/ /-\ `/ |_ /-\ |\| > Waylan Limberg |