From: Eric A. <gi...@gm...> - 2009-01-27 15:51:09
|
On Jan 27, 2009, at 11:23 PM, Waylan Limberg wrote: > On Tue, Jan 27, 2009 at 9:58 AM, Eric Abrahamsen <gi...@gm...> > wrote: >> >> Hey there, I've finally got this working. I tried some clever stuff >> with >> subclassing ElementTree, but it was impossible to make work given the >> variety of ElementTrees we might be working with, so I went with the >> brute-force method: copying large chunks of code out of etree1.3. >> I've now >> got something that works as expected with Python 2.5.1 and >> cElementTree, and >> also made some supporting tests. I have never used git before, and >> I'm >> currently failing to add a branch to the mainline repository -- the >> tutorials I'm reading are not doing the trick. Can you tell me >> simply how to >> put this stuff online? I'm working on master, locally, and all my >> changes >> are committed, but I don't know what to do next... >> >> One thing I don't have here is the ability to test this with the >> full range >> of python/ElementTree version variations. If one of you have a full >> test >> environment, that would be great, otherwise I can install a few more >> versions of python on my development machine (something I'll need >> to do >> sooner or later, anyway). Hope all this works out! Let me know what >> to do >> next. >> > > Well, you probably don't have commit access to the mainline repo. What > you should do is create your own cloned repo on gitorious and push to > that. Then we can review the code, pull it down and merge it into the > mainline and push it back up. I'm currently struggling to make git/gitorious use the proper set of ssh keys. I'm going to give up in about twenty seconds and email a diff. > Or, you always could just create a patch and email it to me (and the > list). Then I could review and apply the patch and push from there. > > Speaking of emailing to the list, I noticed you haven't been replying > to the list - only me. I've been trying to add the list back in on my > replies, but may have missed a few. We prefer to keep these > discussions on the list for a few reasons: they are archived for later > reference, and others have an opportunity to contribute etc. Could you > try to remember to hit "reply to all" rather than "reply" in your > email client? I realize we all forget sometimes and I don't mean to be > whiny, but a helpful reminder is good sometimes. I thought it was you who'd first emailed me off-list :) Of course I'm happy to keep this on-list. > Btw, I have a full testing environment, so I can take care of that. > For those that care, I recently documented how I set it up here: > > http://achinghead.com/archive/83/installing-multiple-versions-python/ Excellent, I'll give these instructions a shot, and am happy that you can take care of it in the meantime... E > > -- > ---- > \X/ /-\ `/ |_ /-\ |\| > Waylan Limberg |