From: Yuri T. <qar...@gm...> - 2008-08-26 07:45:47
|
Waylan, thanks for noticing this! How confident do you feel about the tests at this point? Perhaps we should do more test testing. I just tried running John Gruber's test suite (MarkdownTest.pl) with --tidy option and it appears that the current version does pass the old version of the test (from 2004), which is what I used before writing test_markdown.py. However, it fails some of the new ones. This is not a regression, since those represent the more recent changes to Markdown.pl and we most probably never passed them. Just so that we are all on the same page, I committed those tests into our tree. I also modified MarkdownTest.pl to work with the version of tidy that came with Ubuntu 7.10. To run older tests: perl MarkdownTest/MarkdownTest.pl --tidy --script ./markdown.py --testdir MarkdownTest/Tests_2004 (this will pass) perl MarkdownTest/MarkdownTest.pl --tidy --script ./markdown.py --testdir MarkdownTest/Tests_2007 (some of those will fail) - yuri >> I fixed bugs, all test, except codehilite and wikilink passes now, by >> the way the same problems exists in Markdown 1.7, it's legacy problems. >> > Thanks Artem. Well, yes, the bug you fixed was legacy, but the ones I > fixed yesterday were not. See commit fa014ac. I only changed one line > in markdown.py, yet the patch included 956 lines changed in 18 files. > The rest were all changes to the tests - tests that used to be right > back in 1.7. -- http://sputnik.freewisdom.org/ |