[Python-markdown-discuss] Lying tests

[Waylan L. <wa...@gm...>]

Just an FYI to everyone. I've come to realize more than ever today
that just because the tests included in the repo are passing does not
mean *anything*. If you look at the numerous commits I've made today,
most are changes to the tests themselves. I've spent hours fixing bad
tests and only minutes on actual bugs in the code.

It seems that when the tests were altered to fit the output of
ElemenTree, a large number of new bugs have been introduced into the
tests. So while it looks like everything is ok - I've found a few
glaring blunders. The only way to catch them is to either do your own
testing outside the provided tests and fix the bugs  - then run the
tests and fix all the tests that fail, or to review each and every
test by hand and try to spot problems.

I've been doing the former, and in the process I've looked at a few
tests and discovered additional problems. When I have, I've been
updating the tests to what they should be *even if I haven't fixed the
bug*. That means those tests are still failing. Please don't change
the test - fix the bug so the test passes. Or, if you disagree with
what the test should expect, bring it up here for discussion.

Even better, spend some time reviewing the tests for more errors and
submit patches. :-)

-- 
----
Waylan Limberg
wa...@gm...