Re: [Python-markdown-discuss] [PATCH] unwrapping urlparse result tuple manually for python 2.4 compatibility.

[Waylan L. <wa...@gm...>]

On Fri, May 30, 2008 at 6:18 PM, Yuri Takhteyev <qar...@gm...> wrote:
> Thanks.  I pushed this commit.  Sorry about this, not sure when this
> has slipped in.  My goal has been to keep compatibility not only with
> 2.4 but also with 2.3.  I also noticed that while markdown.py works
> with 2.3 (well used to, and now again with your patch), the
> test-markdown.py script did not.  So, I changed test-markdown.py to
> work with 2.3.
>
> So, let's all agree that test-markdown.py should be ran with
> python2.3, python2.4 and python2.5 after each change.  If you cannot
> check it with all three, then make a commit in a branch and email it
> to me so that I could test before merging.

Yeah, I forget to test in multiple versions sometimes. Thanks for the reminder.
>
> Also, Waylan and David, can you check in test cases for the fixes you
> made in the recent months?

I've been adding tests for most of the changes I make. There's just
been a few things that aren't directly related to the syntax. And,
IIRC, David has made very few syntax changes - all with tests.
>
> BTW, I also noticed that we have a regression on one of the tests.  I
> suspect this might be the price we are paying for some of the other
> issues that Waylan fixed.

Yes, but I forget which one now. Anyway, I wasn't worried about it
because the test shouldn't have been passing anyway. If you look at
the html file for that test it is obvious that that is not the
intended result. I'd rather have it fail than create some false sense
that it's passing.

> Hopefully we'll resolve this with Artem's
> help over the next few months.

Yeah, if he's working on how InlinePatterns nest, that should fix the issue.



-- 
----
Waylan Limberg
wa...@gm...