Re: [Python-markdown-discuss] mdx_tables bug

[Waylan L. <wa...@gm...>]

Bah, I failed to copy the list with my response. Here it is:

On Fri, May 2, 2008 at 11:33 AM, Waylan Limberg <wa...@gm...> wrote:
> Glin, thanks for your report. Personally, I have never used that
>  extension and don't even know if it works.
>
>  In any event, regarding your comments about _handleInline and
>  _handleInlineWrapper; those methods have been in flux. It used to be
>  that there was only _handleInline. Then _handleInlineWrapper was added
>  to wrap the first method. Later, the wrapper stopped calling
>  _handleInline altogether and did everything on it's own. As
>  _handleInline was still in the code, but (mostly) unused, this caused
>  all sorts of confusion.
>
>  Therefore in the latest release (1.7) the unused code was removed and
>  there is only one method _handleInline. I'd suggest upgrading to the
>  latest release of markdown and then see how it works.
>
>

On Fri, May 2, 2008 at 1:44 PM, Yuri Takhteyev <qar...@gm...> wrote:
> >  IMHO this extension shouldn't use _handleInline method, but
>  >  _handleInlineWrapper2. I went through the source code of markdown and it
>  >  appears, that _handleInline is only some 'private' function used by
>  >  _handleInlineWrapper2 - so _handleInline applies only one pattern and
>  >  returns chunks in reverse order, which is completely wrong and will do
>  >  mess when you use any inline pattern in table.
>
>  Thanks for pointing this out.  Strictly speaking, the extensions
>  shouldn't be using an of the _... methods.  So, we should probably
>  think whether this is a sign that we need to expose a bit more of the
>  API.  Anyway, I'll try to look into this.

As I was typing my response, this occurred to me as well. Perhaps at
the least we should provide a public method that wraps the private
method. Something like, handleInline(*args  **kwargs). That way, it is
both backward and forward compatible. However, I believe the gSOC
project will be addressing the inline patterns directly, so perhaps we
should wait and see what comes out of that before setting a new API.

>
>
>  >  I don't have permission to wiki so I cannot write it there, so I'm
>  >  sending this email to mailinglist.
>
>  We switched to git last week and I just checked in additional
>  extensions that I have, including this one.
>
>  The project is at http://gitorious.org/projects/python-markdown/ and
>  the "mainline" repository is at
>  http://gitorious.org/projects/python-markdown/repos/mainline/
>
Cool! Any reason why you didn't commit the latest versions of my
extensions (wikilink & codehilite)? I'll update them if you didn't
have any specific reason.

Anyway while were at it, mind if I add some more (I have 7 total) to
the mainline or would you prefer elsewhere for now?



-- 
----
Waylan Limberg
wa...@gm...