python-ldap-dev

Re: [PATCH] Plug two leaks in python-ldap

[<mi...@st...>]

Xin LI wrote:
> 
> Here is a patch that corrects two memory leaks in python-ldap.  Tracker
> #1464085.

Thanks for submitting the patch.
Do you have Python code demonstrating the leak?

Do you add the ldap_msgfree(msg) because LDAPmessage_to_python() is not
called in these error cases?

> BTW.  Is there any plan to release a new version soon?

I could release a new version very soon. (Despite that SF sucks and
again I can't contact the CVS repository via SSH at the moment.)

Note that as already stated in CVS version of CHANGES upcoming
python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for the build.

Ciao, Michael.

Re: [PATCH] Plug two leaks in python-ldap

[<mi...@st...>]

Xin LI wrote:
> 
> Here is a patch that corrects two memory leaks in python-ldap.  Tracker
> #1464085.

I've committed this patch. Not sure when it will appear in anon CVS
since SF has some problems with CVS service.

Ciao, Michael.

Re: [PATCH] Plug two leaks in python-ldap

[Xin LI <de...@de...>]

Hi, Michael,

=E5=9C=A8 2006-04-04=E4=BA=8C=E7=9A=84 12:16 +0200=EF=BC=8CMichael Str=C3=
=B6der=E5=86=99=E9=81=93=EF=BC=9A
> Thanks for submitting the patch.
> Do you have Python code demonstrating the leak?

By searching a non-existent entry DN from LDAP server, it would end up
with the error path and got the leak.

> Do you add the ldap_msgfree(msg) because LDAPmessage_to_python() is not
> called in these error cases?

Yes.  It takes me some minutes to figure out that the ldap message was
actually free'ed by LDAPmessage_to_python() in the usual path :-)

> > BTW.  Is there any plan to release a new version soon?
>=20
> I could release a new version very soon. (Despite that SF sucks and
> again I can't contact the CVS repository via SSH at the moment.)
>=20
> Note that as already stated in CVS version of CHANGES upcoming
> python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for the build=
.

Glad to hear that :-)  Thanks!

Cheers,
--=20
Xin LI <delphij delphij net>    http://www.delphij.net/

Planning python-ldap release 2.2.0

[<mi...@st...>]

Xin LI wrote:
> 
>>>BTW.  Is there any plan to release a new version soon?
>>
>>I could release a new version very soon. (Despite that SF sucks and
>>again I can't contact the CVS repository via SSH at the moment.)
>>
>>Note that as already stated in CVS version of CHANGES upcoming
>>python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for the build.
> 
> Glad to hear that :-)  Thanks!

How soon would you need a new release version in your project?

Anyone else on the list should comment now(!) about the new requirement
for OpenLDAP libs 2.2.

Ciao, Michael.

Re: Planning python-ldap release 2.2.0

[Jens V. <je...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 4 Apr 2006, at 11:27, Michael Str=F6der wrote:
>>> Note that as already stated in CVS version of CHANGES upcoming
>>> python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for =20
>>> the build.
>>
>> Glad to hear that :-)  Thanks!
>
> How soon would you need a new release version in your project?
>
> Anyone else on the list should comment now(!) about the new =20
> requirement
> for OpenLDAP libs 2.2.

I have no problem with it.

You'll probably end up with more support questions, though, because =20
this requirement shuts out people on RH9/RHEL3/FC3 and earlier who =20
use the distribution-provided OpenLDAP.

jens

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFEMk3gRAx5nvEhZLIRAgNlAJ9ihSDHwO11MEoSRJh2rocRWdpQvQCguUgl
Fp9U8/1waBJo3tZpAFPnQ7g=3D
=3DQwLk
-----END PGP SIGNATURE-----

Re: Planning python-ldap release 2.2.0

[<mi...@st...>]

Jens Vagelpohl wrote:
>>> Anyone else on the list should comment now(!) about the new  requirement
>>> for OpenLDAP libs 2.2.
> 
> I have no problem with it.
> 
> You'll probably end up with more support questions, though, because 
> this requirement shuts out people on RH9/RHEL3/FC3 and earlier who  use
> the distribution-provided OpenLDAP.

Yes, I expect these people to request support for OpenLDAP 2.0.x. But
people not willing to use a C compiler probably will have to stick to
older python-ldap releases anyway. ;-)

Ciao, Michael.

Re: Planning python-ldap release 2.2.0

[Jens V. <je...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 4 Apr 2006, at 11:50, Michael Str=F6der wrote:

> Jens Vagelpohl wrote:
>>>> Anyone else on the list should comment now(!) about the new  =20
>>>> requirement
>>>> for OpenLDAP libs 2.2.
>>
>> I have no problem with it.
>>
>> You'll probably end up with more support questions, though, because
>> this requirement shuts out people on RH9/RHEL3/FC3 and earlier =20
>> who  use
>> the distribution-provided OpenLDAP.
>
> Yes, I expect these people to request support for OpenLDAP 2.0.x. But
> people not willing to use a C compiler probably will have to stick to
> older python-ldap releases anyway. ;-)

Yes, absolutely, I just fear those people who have this irrational =20
urge to upgrade just for upgrading's sake if something new is =20
released, and a lot of them don't like answers such as "If you're on =20
OL 2.0.27, please use python-ldap versions <=3D 2.0.10 because the =20
newest versions won't run against your antique OpenLDAP". :P

jens

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFEMlCyRAx5nvEhZLIRAlcEAJ9qkLi35DctFo9MZzjwK+zs/ZqI3gCgkm9V
klufummU/drZLg/YKMvm8xY=3D
=3DoajH
-----END PGP SIGNATURE-----

Re: Planning python-ldap release 2.2.0

[<pk...@gm...>]

Jens Vagelpohl wrote:
>=20
> On 4 Apr 2006, at 11:50, Michael Str=F6der wrote:
>>> Yes, I expect these people to request support for OpenLDAP 2.0.x. But=

>>> people not willing to use a C compiler probably will have to stick to=

>>> older python-ldap releases anyway. ;-)
>=20
> Yes, absolutely, I just fear those people who have this irrational urge=

> to upgrade just for upgrading's sake if something new is released, and =
a
> lot of them don't like answers such as "If you're on OL 2.0.27, please
> use python-ldap versions <=3D 2.0.10 because the newest versions won't =
run
> against your antique OpenLDAP". :P
>=20
> jens
Let's hope that the "irrational urge to upgrade" will solve the OL 2.0.x
issue for them as well.

cheers
 Paul

Re: Planning python-ldap release 2.2.0

[Xin LI <de...@de...>]

=E5=9C=A8 2006-04-04=E4=BA=8C=E7=9A=84 12:27 +0200=EF=BC=8CMichael Str=C3=
=B6der=E5=86=99=E9=81=93=EF=BC=9A
> Xin LI wrote:
> >=20
> >>>BTW.  Is there any plan to release a new version soon?
> >>
> >>I could release a new version very soon. (Despite that SF sucks and
> >>again I can't contact the CVS repository via SSH at the moment.)
> >>
> >>Note that as already stated in CVS version of CHANGES upcoming
> >>python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for the bui=
ld.
> >=20
> > Glad to hear that :-)  Thanks!
>=20
> How soon would you need a new release version in your project?

It's kind of you, Michael.  For my own project it's not an urgent need
as I can deploy patched version to fulfill my need, but I would happy to
see if you guys would release a new release, so we can update the
FreeBSD port (currently it's 2.0.10) without adding "local patchset" to
the FreeBSD ports repository.

Cheers,
--=20
Xin LI <delphij delphij net>    http://www.delphij.net/

Re: [PATCH] Plug two leaks in python-ldap

[<mi...@st...>]

Xin LI wrote:
>=20
> 12:16 +0200=EF=BC=8CMichael Str=C3=B6der=EF=BC=9A
>=20
>>Thanks for submitting the patch.
>>Do you have Python code demonstrating the leak?
>=20
> By searching a non-existent entry DN from LDAP server, it would end up
> with the error path and got the leak.
>=20
>>Do you add the ldap_msgfree(msg) because LDAPmessage_to_python() is not
>>called in these error cases?
>=20
> Yes.  It takes me some minutes to figure out that the ldap message was
> actually free'ed by LDAPmessage_to_python() in the usual path :-)

Ok, will commit your patch ASAP.

Ciao, Michael.