python-ldap-dev

Setting options via class attributes of LDAPObject

[<mi...@st...>]

HI!

I'd like to remove the possibility to set/get LDAP options via 
class attributes of ldap.LDAPObject instances since it's 
error-prone and kludgy code.

LDAPObject.set_option() and LDAPObject.get_option() is the 
complete solution.

Although it might break existing code if I remove 
LDAPObject.__setattr__() and LDAPObject.__getattr__(). Therefore 
I'd like to ask who is setting LDAP options via class attributes?

Ciao, Michael.

Re: Setting options via class attributes of LDAPObject

[<mi...@st...>]

Michael Str=F6der wrote:
>=20
> I'd like to remove the possibility to set/get LDAP options via class=20
> attributes of ldap.LDAPObject instances since it's error-prone and=20
> kludgy code.
>=20
> LDAPObject.set_option() and LDAPObject.get_option() is the complete=20
> solution.
>=20
> Although it might break existing code if I remove=20
> LDAPObject.__setattr__() and LDAPObject.__getattr__(). Therefore I'd=20
> like to ask who is setting LDAP options via class attributes?

Hmm, I've checked in a much less complex implementation of=20
LDAPObject.__setattr__() and LDAPObject.__getattr__().

But I'd really like to remove getattr() and setattr() in=20
LDAPObject.c since it does not make sense to do this at the C=20
level. But if I remove getattr() and setattr() the set_option()=20
and get_option() method are also removed.

David, can you please enlighten me how the stuff in options.c=20
works? It seems somewhat overly complex to me.

Ciao, Michael.

Re: Setting options via class attributes of LDAPObject

[Jens V. <je...@zo...>]

+1

IMHO direct attribute access without going through methods is nasty

jens


On Thursday, July 25, 2002, at 11:34 , Michael Str=F6der wrote:

> HI!
>
> I'd like to remove the possibility to set/get LDAP options via class=20=

> attributes of ldap.LDAPObject instances since it's error-prone and =
kludgy=20
> code.
>
> LDAPObject.set_option() and LDAPObject.get_option() is the complete=20
> solution.
>
> Although it might break existing code if I remove=20
> LDAPObject.__setattr__() and LDAPObject.__getattr__(). Therefore I'd =
like=20
> to ask who is setting LDAP options via class attributes?
>
> Ciao, Michael.