python-ldap-dev

Cygwin Patch

[Jason T. <Jas...@do...>]

On Sun, 10 Dec 2000 23:27:49 +0100, David Leonard wrote:
> 	* python-ldap-1.10 will be tidied up, with just the memory-leak
> 	  patches applied, and a proper documentation build. (ie no v3
> 	  changes will be applied as it breaks v2 builds.) A final release
> 	  will be made.

Hopefully, the attached patch (against python-ldap-1.10alpha3) can
still be considered for inclusion in the 1.10 final release.  It enables
python-ldap to build OOTB as a shared extension for Cygwin Python.

Cygwin is an open-source POSIX emulation layer that enables many
GNU and UNIX tools to port to Windows without any source code changes.
If interested, please see http://www.cygwin.com for more information.

Note that the patch has no functional changes -- it only enables the
code to compile cleanly with Cygwin gcc.  Specifically, the changes
are as follows:

    1. replaced #ifdef WIN32 with #if defined(WIN32) || defined(__CYGWIN__) 
       as described in http://www.python.org/doc/FAQ.html#3.24 
    2. added DL_EXPORT to init_ldap() 

I'm quite willing to redo the patch against python-ldap CVS if that
will facilitate its acceptance.

My original plan was to wait until the Cygwin Python DLL and Shared
Extension Patch:

    http://sourceforge.net/patch/?func=detailpatch&patch_id=102409&group_id=5470

was accepted and committed into Python CVS before contacting the list.
However, due to the impending 1.10 final release, I realized that it
would be prudent to submit the patch sooner rather than later.

The procedure to apply the patch (to python-ldap-1.10alpha3) is as follows:

    $ cd python-ldap-1.10alpha3
    $ # save the attachment to the current directory
    $ patch -p1 <Cygwin-python-ldap-1.10alpha3.patch

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jas...@do...
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

Re: Cygwin Patch

[Michael <mi...@st...>]

Jason Tishler wrote:
> 
> python-ldap to build OOTB as a shared extension for Cygwin Python.

Which leads to the question whether you can provide pre-compiled
Win32 binaries of python-ldap for download.

Ciao, Michael.

Re: Cygwin Patch

[Jason T. <Jas...@do...>]

Michael,

On Wed, Dec 27, 2000 at 04:50:21PM +0100, Michael Str=F6der wrote:
> Jason Tishler wrote:
> >=20
> > python-ldap to build OOTB as a shared extension for Cygwin Python.
>=20
> Which leads to the question whether you can provide pre-compiled
> Win32 binaries of python-ldap for download.

I was going to offer to provide pre-built binaries in my previous email,
but I thought that it would be considered presumptuous without waiting
to see if the patch would be accepted.

There are also other issues regarding the usefulness of the pre-built
binary:

    1. Cygwin python-ldap is *not* a Mingw (i.e., straight Win32) binary
       and requires Cygwin's cygwin1.dll to run
    2. Cygwin python-ldap requires Cygwin Python to be built with a DLL c=
ore
       (similar to Win32 Python)

Additionally, I was hoping to store the pre-built binary on

    http://python-ldap.sourceforge.net/release.php

since my public web space is currently very limited.

Nevertheless, I can provide the following packages that are installable
with Cygwin's setup.exe:

    python-ldap-1.10alpha3-1.tar.gz: Cygwin python-ldap
    python-20001116-1.tar.gz:        Cygwin Python 2.0 with DLL core
    openldap-1.2.11-1.tar.gz:        Cygwin OpenLDAP 1.2.11 clients and l=
ibs

Only the first one above is required.  The other two are offered for
convenience only -- it makes more sense for them to be contributed to
the Cygwin project instead.

Jason

--=20
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jas...@do...
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

Re: Cygwin Patch

[Jason T. <Jas...@do...>]

My Cygwin patches to Python have been accepted into Python CVS so
Cygwin Python has supported shared extensions since 2.1a1.  I have
redone my Cygwin python-ldap patch against the current python-ldap CVS.
Please consider this patch for acceptance into python-ldap CVS.

The procedure to apply the patch is as follows:

    $ # save the attachment to /tmp
    $ cd python-ldap/Modules
    $ patch </tmp/cygwin.patch

See the following for my original posting:

On Wed, Dec 27, 2000 at 09:37:50AM -0500, Jason Tishler wrote:
> On Sun, 10 Dec 2000 23:27:49 +0100, David Leonard wrote:
> > 	* python-ldap-1.10 will be tidied up, with just the memory-leak
> > 	  patches applied, and a proper documentation build. (ie no v3
> > 	  changes will be applied as it breaks v2 builds.) A final release
> > 	  will be made.
> 
> Hopefully, the attached patch (against python-ldap-1.10alpha3) can
> still be considered for inclusion in the 1.10 final release.  It enables
> python-ldap to build OOTB as a shared extension for Cygwin Python.
> 
> Cygwin is an open-source POSIX emulation layer that enables many
> GNU and UNIX tools to port to Windows without any source code changes.
> If interested, please see http://www.cygwin.com for more information.
> 
> Note that the patch has no functional changes -- it only enables the
> code to compile cleanly with Cygwin gcc.  Specifically, the changes
> are as follows:
> 
>     1. replaced #ifdef WIN32 with #if defined(WIN32) || defined(__CYGWIN__) 
>        as described in http://www.python.org/doc/FAQ.html#3.24 
>     2. added DL_EXPORT to init_ldap() 
> 
> I'm quite willing to redo the patch against python-ldap CVS if that
> will facilitate its acceptance.
> 
> My original plan was to wait until the Cygwin Python DLL and Shared
> Extension Patch:
> 
>   http://sourceforge.net/patch/?func=detailpatch&patch_id=102409&group_id=5470
> 
> was accepted and committed into Python CVS before contacting the list.
> However, due to the impending 1.10 final release, I realized that it
> would be prudent to submit the patch sooner rather than later.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jas...@do...
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

Re: Cygwin Patch

[Jason T. <Jas...@do...>]

On Tue, Mar 06, 2001 at 11:14:21AM -0500, Jason Tishler wrote:
> My Cygwin patches to Python have been accepted into Python CVS so
> Cygwin Python has supported shared extensions since 2.1a1.  I have
> redone my Cygwin python-ldap patch against the current python-ldap CVS.
> Please consider this patch for acceptance into python-ldap CVS.

David was kind enough to give me write access to python-ldap CVS.  So,
I just committed the above patch.

If the changes cause anyone some heartache, please holler.  Although
I don't expect any problems, since this patch is the same in spirit to a
few of my patches that have been applied to the Python standard modules.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jas...@do...
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com