python-ldap-dev — discussion among developers

Re: Problem parsing LDIF change records

[Roland H. <rol...@ad...>]

Michael Str=F6der wrote:
> Roland Hedberg wrote:
>> Roland Hedberg wrote:
>>
>>> I'm having problem with LDIFParser and LDIF change records.
>>> I'm using 2.2.0 which to my knowledge is the last official release.
>> No offence, but has anybody ever used python-ldap to handle LDIF chang=
e
>> records ?
>=20
> No, change records are not supported yet.
>=20
>> Working my way down into the code, it becomes more and more obvious th=
at
>> there is no way it would have worked as expected.
>=20
> Never had the spare time to finish it especially since I didn't have a
> clear plan on how to handle different LDAP operations. One idea was to
> implement separate methods like handle_op_add(), handle_op_modify(),
> handle_op_delete()...
>=20
> I'd appreciate if you could fix it. Patches welcome. If it turns out
> that it's necessary to change the class API completely it might be a
> good idea to implement a separate class (or even a separate module).

Well, since I need it, I'll have to fix it !

When I have something I'll submit it for review.

> See also SF#790789:
> http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D790789&gro=
up_id=3D2072&atid=3D352072

Goodness gracious, this is exactly the path I've chosen so far.
And without even knowing about this ticket.

-- Roland

Re: Problem parsing LDIF change records

[<mi...@st...>]

Roland Hedberg wrote:
> Roland Hedberg wrote:
> 
>>I'm having problem with LDIFParser and LDIF change records.
>>I'm using 2.2.0 which to my knowledge is the last official release.
> 
> No offence, but has anybody ever used python-ldap to handle LDIF change
> records ?

No, change records are not supported yet.

> Working my way down into the code, it becomes more and more obvious that
> there is no way it would have worked as expected.

Never had the spare time to finish it especially since I didn't have a
clear plan on how to handle different LDAP operations. One idea was to
implement separate methods like handle_op_add(), handle_op_modify(),
handle_op_delete()...

I'd appreciate if you could fix it. Patches welcome. If it turns out
that it's necessary to change the class API completely it might be a
good idea to implement a separate class (or even a separate module).

See also SF#790789:
http://sourceforge.net/tracker/index.php?func=detail&aid=790789&group_id=2072&atid=352072

Ciao, Michael.

Re: Problem parsing LDIF change records

[Ingo S. <st...@un...>]

Am Freitag, 29. September 2006 10:33 schrieb Roland Hedberg:
> Roland Hedberg wrote:
> > Hi!
> >
> > I'm having problem with LDIFParser and LDIF change records.
> > I'm using 2.2.0 which to my knowledge is the last official release.
>
> No offence, but has anybody ever used python-ldap to handle LDIF change
> records ?
>
> Working my way down into the code, it becomes more and more obvious that
> there is no way it would have worked as expected.

AFAIK support for LDAP-modlists is not implemented, only import of 
LDAP-objects.

Ingo Steuwer

> -- Roland
>
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your opinions on IT & business topics through brief surveys -- and earn
> cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Python-LDAP-dev mailing list
> Pyt...@li...
> https://lists.sourceforge.net/lists/listinfo/python-ldap-dev

-- 

Ingo Steuwer       st...@un...         fon: +49 421 22 232- 0
Projektmanagement  Linux for Your Business
Univention GmbH    http://www.univention.de/     fax: +49 421 22 232-99

Re: Problem parsing LDIF change records

[Roland H. <rol...@ad...>]

Roland Hedberg wrote:
> Hi!
> 
> I'm having problem with LDIFParser and LDIF change records.
> I'm using 2.2.0 which to my knowledge is the last official release.

No offence, but has anybody ever used python-ldap to handle LDIF change
records ?

Working my way down into the code, it becomes more and more obvious that
there is no way it would have worked as expected.

-- Roland

Problem parsing LDIF change records

[Roland H. <rol...@ad...>]

Hi!

I'm having problem with LDIFParser and LDIF change records.
I'm using 2.2.0 which to my knowledge is the last official release.

The problematic line is line 382 in LDIFParser.parse(), the last one of
the following snippet.

       elif attr_type=='changetype':
          # attr type and value pair was DN of LDIF record
          if dn is None:
            raise ValueError, 'Read changetype: before getting valid dn:
line.'
          if changetype!=None:
            raise ValueError, 'Two lines starting with changetype: in
one record.'
          if not valid_changetype_dict.has_key(attr_value):
            raise ValueError, 'changetype value %s is invalid.' %
(repr(attr_value))
          dn = attr_value

What happens here is that you replace the dn value, that you earlier has
picked up from the LDIF record, with the change type.

There is no easy way to figure out the dn later in the process and if
you like me really, really need the dn then you're lost.

So, to solve my problem, I've change the last line to:

	changetype = attr_value

And then futher down the line

	self.handle(dn,entry,changetype)

Which of course means I have to change the definition of handle to

	def handle(self,dn,entry,changetype=None):

I get the impression from the code that this was the intention but then
somehow the coder got sidestepped :-)


-- Roland

Re: Can't Import LDAP

[Ted J. <wha...@ya...>]

2

LI Xin <de...@de...> wrote: Hi, Ted,

Ted Johnson wrote:
> Hi;
> I'm on FreeBSD 6.1. I've successfully installed OpenLDAP from the port
> (I can issue commands to the s/w at the prompt) and it appears I've done
> the same with py-ldap2 (don't know what commands to issue, but FreeBSD
> says the s/w was loaded successfully). However, when I fire up my Python
> interpreter and enter "import ldap" I'm told no such module exists. 
> What could I be doing wrong?

I do use py-ldap2 on FreeBSD a lot, and I think I have did a good job on
the port ;-) so I would like to help out.

Which python release do you use?  

2.3.5

Will you please check the output of
'pkg_info -L py24-ldap2-2.2.0' to confirm that it has installed the
stuff into your python installation's site-packages/ directory?

Here it is, thanks for your help, and TIA for any further direction you can provide.
Ted

server167# pkg_info -L py24-ldap2-2.2.0
Information for py24-ldap2-2.2.0:

Files:
/usr/local/lib/python2.4/site-packages/dsml.py
/usr/local/lib/python2.4/site-packages/dsml.pyc
/usr/local/lib/python2.4/site-packages/dsml.pyo
/usr/local/lib/python2.4/site-packages/ldap/__init__.py
/usr/local/lib/python2.4/site-packages/ldap/__init__.pyc
/usr/local/lib/python2.4/site-packages/ldap/__init__.pyo
/usr/local/lib/python2.4/site-packages/ldap/async.py
/usr/local/lib/python2.4/site-packages/ldap/async.pyc
/usr/local/lib/python2.4/site-packages/ldap/async.pyo
/usr/local/lib/python2.4/site-packages/ldap/cidict.py
/usr/local/lib/python2.4/site-packages/ldap/cidict.pyc
/usr/local/lib/python2.4/site-packages/ldap/cidict.pyo
/usr/local/lib/python2.4/site-packages/ldap/controls.py
/usr/local/lib/python2.4/site-packages/ldap/controls.pyc
/usr/local/lib/python2.4/site-packages/ldap/controls.pyo
/usr/local/lib/python2.4/site-packages/ldap/dn.py
/usr/local/lib/python2.4/site-packages/ldap/dn.pyc
/usr/local/lib/python2.4/site-packages/ldap/dn.pyo
/usr/local/lib/python2.4/site-packages/ldap/filter.py
/usr/local/lib/python2.4/site-packages/ldap/filter.pyc
/usr/local/lib/python2.4/site-packages/ldap/filter.pyo
/usr/local/lib/python2.4/site-packages/ldap/functions.py
/usr/local/lib/python2.4/site-packages/ldap/functions.pyc
/usr/local/lib/python2.4/site-packages/ldap/functions.pyo
/usr/local/lib/python2.4/site-packages/ldap/ldapobject.py
/usr/local/lib/python2.4/site-packages/ldap/ldapobject.pyc
/usr/local/lib/python2.4/site-packages/ldap/ldapobject.pyo
/usr/local/lib/python2.4/site-packages/ldap/modlist.py
/usr/local/lib/python2.4/site-packages/ldap/modlist.pyc
/usr/local/lib/python2.4/site-packages/ldap/modlist.pyo
/usr/local/lib/python2.4/site-packages/ldap/sasl.py
/usr/local/lib/python2.4/site-packages/ldap/sasl.pyc
/usr/local/lib/python2.4/site-packages/ldap/sasl.pyo
/usr/local/lib/python2.4/site-packages/ldap/schema/__init__.py
/usr/local/lib/python2.4/site-packages/ldap/schema/__init__.pyc
/usr/local/lib/python2.4/site-packages/ldap/schema/__init__.pyo
/usr/local/lib/python2.4/site-packages/ldap/schema/models.py
/usr/local/lib/python2.4/site-packages/ldap/schema/models.pyc
/usr/local/lib/python2.4/site-packages/ldap/schema/models.pyo
/usr/local/lib/python2.4/site-packages/ldap/schema/subentry.py
/usr/local/lib/python2.4/site-packages/ldap/schema/subentry.pyc
/usr/local/lib/python2.4/site-packages/ldap/schema/subentry.pyo
/usr/local/lib/python2.4/site-packages/ldap/schema/tokenizer.py
/usr/local/lib/python2.4/site-packages/ldap/schema/tokenizer.pyc
/usr/local/lib/python2.4/site-packages/ldap/schema/tokenizer.pyo
/usr/local/lib/python2.4/site-packages/ldapurl.py
/usr/local/lib/python2.4/site-packages/ldapurl.pyc
/usr/local/lib/python2.4/site-packages/ldapurl.pyo
/usr/local/lib/python2.4/site-packages/ldif.py
/usr/local/lib/python2.4/site-packages/ldif.pyc
/usr/local/lib/python2.4/site-packages/ldif.pyo
/usr/local/lib/python2.4/site-packages/_ldap.so



 __________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: Can't Import LDAP

[LI X. <de...@de...>]

Hi, Ted,

Ted Johnson wrote:
> Hi;
> I'm on FreeBSD 6.1. I've successfully installed OpenLDAP from the port
> (I can issue commands to the s/w at the prompt) and it appears I've don=
e
> the same with py-ldap2 (don't know what commands to issue, but FreeBSD
> says the s/w was loaded successfully). However, when I fire up my Pytho=
n
> interpreter and enter "import ldap" I'm told no such module exists.=20
> What could I be doing wrong?

I do use py-ldap2 on FreeBSD a lot, and I think I have did a good job on
the port ;-) so I would like to help out.

Which python release do you use?  Will you please check the output of
'pkg_info -L py24-ldap2-2.2.0' to confirm that it has installed the
stuff into your python installation's site-packages/ directory?

Cheers,
--=20
Xin LI <de...@de...>	http://www.delphij.net/
FreeBSD - The Power to Serve!

Can't Import LDAP

[Ted J. <wha...@ya...>]

Hi;
I'm on FreeBSD 6.1. I've successfully installed OpenLDAP from the port (I can issue commands to the s/w at the prompt) and it appears I've done the same with py-ldap2 (don't know what commands to issue, but FreeBSD says the s/w was loaded successfully). However, when I fire up my Python interpreter and enter "import ldap" I'm told no such module exists.  What could I be doing wrong?
TIA.
Ted
2
 		
---------------------------------
Do you Yahoo!?
 Get on board. You're invited to try the new Yahoo! Mail.

Re: pybots testing

[Sidnei da S. <si...@en...>]

On Wed, Sep 27, 2006 at 02:31:34PM -0300, Sidnei da Silva wrote:
| I will collect the output and mail you.

So actually looks like it's just one test that's failing. Don't know for sure if I'm finding all of them this way though:

C:\src\python-ldap-2.2.0>find . -name '*test*' -print | xargs -I '@' python '@'
String: "BLUBBER DI 'BLU'BB ER' DA 'BLAH' "
=> ['BLUBBER', 'DI', 'BLU', 'BB', 'ER', ' DA ', 'BLAH', ' ']
differs from ['BLUBBER', 'DI', "BLU'BB ER", 'DA', 'BLAH']

Testing function addModlist():

Testing function modifyModlist():

Testing function isLDAPUrl():

Testing class LDAPUrl:
########################################################################
ldap://root.openldap.org/dc%3Dopenldap%2Cdc%3Dorg???
Parsing ok
Unparsing ok
########################################################################
ldap://root.openldap.org/dc%3Dboolean%2Cdc%3Dnet???%28objectClass%3D%2A%29
Parsing ok
Unparsing ok
########################################################################
ldap://root.openldap.org/dc%3Dopenldap%2Cdc%3Dorg??sub?
Parsing ok
Unparsing ok
########################################################################
ldap://root.openldap.org/dc%3Dopenldap%2Cdc%3Dorg??one?
Parsing ok
Unparsing ok
########################################################################
ldap://root.openldap.org/dc%3Dopenldap%2Cdc%3Dorg??base?
Parsing ok
Unparsing ok
########################################################################
ldap://x500.mh.se/o%3DMitthogskolan%2Cc%3Dse????1.2.752.58.10.2=T.61
Parsing ok
Unparsing ok
########################################################################
ldap://localhost:12345/dc%3Dstroeder%2Cdc%3Dcom????!bindname=cn=Michael%2Cdc=str
oeder%2Cdc=com,!X-BINDPW=secretpassword
Parsing ok
Unparsing ok
########################################################################
ldap://localhost:54321/dc%3Dstroeder%2Cdc%3Dcom????bindname=cn=Michael%2Cdc=stro
eder%2Cdc=com,X-BINDPW=secretpassword
Parsing ok
Unparsing ok
########################################################################
ldaps://localhost:12345/dc%3Dstroeder%2Cdc%3Dcom???
Parsing ok
Unparsing ok
########################################################################
ldapi://%2Ftmp%2Fopenldap2-1389/dc%3Dstroeder%2Cdc%3Dcom???
Parsing ok
Unparsing ok


-- 
Sidnei da Silva
Enfold Systems                http://enfoldsystems.com
Fax +1 832 201 8856     Office +1 713 942 2377 Ext 214

Re: pybots testing

[<mi...@st...>]

Sidnei da Silva wrote:
> On Wed, Sep 27, 2006 at 06:29:05PM +0200, Michael Str=F6der wrote:
> |=20
> | What particular tests are you talking about?
> | What happened when tests failed?
>=20
> I will collect the output and mail you.

Please keep it on the list so it gets archived and can be commented by
others too.

Ciao, Michael.

Re: pybots testing

[Sidnei da S. <si...@en...>]

On Wed, Sep 27, 2006 at 06:29:05PM +0200, Michael Ströder wrote:
| I'm not familiar with what pybots provide. Glancing over the web page I
| decided I don't have enough spare time to dig into it. :-(

Running tests for python-based projects with a debug build of python
2.5 and trunk whenever a checkin happens on the python repository.

| > But apparently it doesn't have much
| > test coverage. Or am I overlooking something? I've tried running the
| > few tests here and some of them fail actually.
| 
| What particular tests are you talking about?
| What happened when tests failed?

I will collect the output and mail you.

-- 
Sidnei da Silva
Enfold Systems                http://enfoldsystems.com
Fax +1 832 201 8856     Office +1 713 942 2377 Ext 214

pybots testing

[<mi...@st...>]

Sidnei da Silva wrote:
> 
> On a related note, I would like to setup some testing for python-ldap
> as part of the pybots [1] project.
> [1] http://pybots.org/

I'm not familiar with what pybots provide. Glancing over the web page I
decided I don't have enough spare time to dig into it. :-(

> But apparently it doesn't have much
> test coverage. Or am I overlooking something? I've tried running the
> few tests here and some of them fail actually.

What particular tests are you talking about?
What happened when tests failed?

Ciao, Michael.

Re: Experimental 2.2.0 Windows Build

[Sidnei da S. <si...@en...>]

On Tue, Sep 26, 2006 at 09:43:50AM -0300, Sidnei da Silva wrote:
| Unfortunately I'm no OpenLDAP guru. I just used the win32 patches from Lucas Bergman available here, which are for the versions I've listed:
| 
|  http://download.bergmans.us/openldap/devel/
| 
| I can try to contact Lucas to see if he can provide patches against
| later versions.

Got a reply. He said new versions of the patches are in the
works. Should be available in the coming week(s).

On a related note, I would like to setup some testing for python-ldap
as part of the pybots [1] project. But apparently it doesn't have much
test coverage. Or am I overlooking something? I've tried running the
few tests here and some of them fail actually.

[1] http://pybots.org/

-- 
Sidnei da Silva
Enfold Systems                http://enfoldsystems.com
Fax +1 832 201 8856     Office +1 713 942 2377 Ext 214

Re: Experimental 2.2.0 Windows Build

[Sidnei da S. <si...@en...>]

| Since OpenLDAP 2.2.x is now considered historic by its developers and
| OpenSSL contains some security-related bugs would it be possible for you
| to build with recent versions of both libs? That would be really great.

Unfortunately I'm no OpenLDAP guru. I just used the win32 patches from Lucas Bergman available here, which are for the versions I've listed:

 http://download.bergmans.us/openldap/devel/

I can try to contact Lucas to see if he can provide patches against
later versions.

-- 
Sidnei da Silva
Enfold Systems                http://enfoldsystems.com
Fax +1 832 201 8856     Office +1 713 942 2377 Ext 214

Re: [patch] fix get_option() crash, make more OPT_X_SASL_* info available.

[<mi...@st...>]

Tom,

thanks for contributing.
Sorry for my late reply. My to do list is out of control.

Could you please provide two separate patches I could commit separately?
Could you please check whether python-ldap still builds with OpenLDAP
2.2.x with your patches?

Thanks in advance.

Ciao, Michael.

Tom McLaughlin wrote:
> Hi, the attached patch is to fix a crash I found with py-ldap when using
> get_option() and to allow getting more OPT_X_SASL_* information with
> get_option().
> 
> 1) The second to last hunk fixes a crash when using get_option() and the
> constant returns a NULL.  I can repeat this crash on FreeBSD with python
> 2.4.3 / py-ldap 2.2.0 / openldap 2.3.24 and on CentOS with python 2.3.4 /
> py-ldap 2.0.1 / openldap 2.2.13.
> [..]
> 2) I wanted to be able to get a user's SASL_MECH, SASL_AUTHCID, and
> SASL_AUTHZID but that information wasn't available through py-ldap...  So
> I made it available. :)  Other than adding more SASL constants to
> Modules/options.c, I made LDAP_OPT_X_SASL_SECPROPS return Py_None with
> LDAP_get_option() because according to ldap.h it is read only.  Trying to
> get ldap.OPT_X_SASL_SECPROPS was returning ldap.SERVER_DOWN for me before
> even though I had SASL_SECPROPS defined.
> 
> Please let me know if there are any questions or comments.  I don't
> actually know C...  I just kinda figured out the changes.  Thanks.
> 
> tom

Re: Experimental 2.2.0 Windows Build

[<mi...@st...>]

Sidnei,

many thanks for contributing this build! I'm sure many people are
appreciating it. I had no spare time to test it though.

Sidnei da Silva wrote:
> 
> I've managed to put together an experimental 2.2.0 build for Windows,
> which can be found here:
> 
>   http://awkly.org/files/python-ldap-2.2.0.win32-py2.4.exe
> [..]
> It was built with mingw against:
> 
>   openldap-2.2.29
>   openssl-0.9.8b

Since OpenLDAP 2.2.x is now considered historic by its developers and
OpenSSL contains some security-related bugs would it be possible for you
to build with recent versions of both libs? That would be really great.

Ciao, Michael.

Re: Compability issues with Python 2.5

[<mi...@st...>]

Keith Jackson wrote:
> I don't have time, but when I converted a bunch of my code I found 
> http://svn.effbot.python-hosting.com/stuff/sandbox/python/ ssizecheck.py
> to be very useful.

Yes, it is. I already checked the code with it. But mainly it does only
search for function names of the C API. I also don't have a 64-bit
machine at hand with decent tool chain. So I won't see compiler warnings
on my local system (SuSE Linux 10.0 i386).

And in some cases I don't know what to do. E.g. when converting to
OpenLDAP's struct berval (handling the length of the berval string).
Hmm, to me it looks ok.

>From OpenLDAP's lber_types.h:
------------------------------ snip ------------------------------
/* LBER lengths (32 bits or larger) */
#define LBER_LEN_T long
[..]
/* lengths */
typedef unsigned LBER_LEN_T ber_len_t;
------------------------------ snip ------------------------------

>From OpenLDAP's lber_types.h:
------------------------------ snip ------------------------------
/* structure for returning a sequence of octet strings + length */
typedef struct berval {
        ber_len_t       bv_len;
        char            *bv_val;
} BerValue;
------------------------------ snip ------------------------------

Ciao, Michael.

Re: Compability issues with Python 2.5

[Keith J. <KRJ...@lb...>]

I don't have time, but when I converted a bunch of my code I found =20
http://svn.effbot.python-hosting.com/stuff/sandbox/python/=20
ssizecheck.py to be very useful.
--keith

On Sep 18, 2006, at 1:45 PM, Michael Str=F6der wrote:

> HI!
>
> I suspect that python-ldap has some issues regarding changes in the C
> API of Python 2.5. web2ldap with recent python-ldap crashes quite =20
> often.
>
> Since my C knowledge is quite bad I need some volunteers. Anyone =20
> willing
> to spend some spare time digging under Modules/ is encouraged to read
> PEP 0353 and "What's New in Python 2.5":
>
> http://docs.python.org/dev/whatsnew/ports.html
>
> http://docs.python.org/dev/whatsnew/section-other.html (last two items
> starting with "C API:")
>
> http://www.python.org/dev/peps/pep-0353/#conversion-guidelines
>
> I've attached a unified patch of my first try to address these issues.
> But I won't commit them now. Please review.
>
> Ciao, Michael.
> Index: Modules/ldapcontrol.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/python-ldap/python-ldap/Modules/ldapcontrol.c,v
> retrieving revision 1.5
> diff -u -r1.5 ldapcontrol.c
> --- Modules/ldapcontrol.c	10 Apr 2006 05:19:46 -0000	1.5
> +++ Modules/ldapcontrol.c	18 Sep 2006 20:38:08 -0000
> @@ -130,7 +130,7 @@
>  LDAPControl**
>  List_to_LDAPControls( PyObject* list )
>  {
> -    int len, i;
> +    Py_ssize_t len, i;
>      LDAPControl** ldcs;
>      LDAPControl* ldc;
>      PyObject* item;
> @@ -173,7 +173,7 @@
>  {
>      PyObject *res =3D 0, *pyctrl;
>      LDAPControl **tmp =3D ldcs;
> -    unsigned num_ctrls =3D 0, i;
> +    Py_ssize_t num_ctrls =3D 0, i;
>
>      if (tmp)
>          while (*tmp++) num_ctrls++;
> Index: Modules/LDAPObject.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/python-ldap/python-ldap/Modules/LDAPObject.c,v
> retrieving revision 1.75
> diff -u -r1.75 LDAPObject.c
> --- Modules/LDAPObject.c	18 Apr 2006 11:17:30 -0000	1.75
> +++ Modules/LDAPObject.c	18 Sep 2006 20:38:09 -0000
> @@ -210,7 +210,7 @@
>  static LDAPMod**
>  List_to_LDAPMods( PyObject *list, int no_op ) {
>
> -    int i, len;
> +    Py_ssize_t i, len;
>      LDAPMod** lms;
>      PyObject *item;
>
> @@ -263,7 +263,7 @@
>  attrs_from_List( PyObject *attrlist, char***attrsp ) {
>
>      char **attrs =3D NULL;
> -    int i, len;
> +    Py_ssize_t i, len;
>      PyObject *item;
>
>      if (attrlist =3D=3D Py_None) {
> Index: Modules/options.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/python-ldap/python-ldap/Modules/options.c,v
> retrieving revision 1.15
> diff -u -r1.15 options.c
> --- Modules/options.c	11 Mar 2006 21:11:40 -0000	1.15
> +++ Modules/options.c	18 Sep 2006 20:38:09 -0000
> @@ -156,7 +156,7 @@
>      LDAPControl *lc;
>      char *strval;
>      PyObject *extensions, *v, *tup;
> -    int i, num_extensions, num_controls;
> +    Py_ssize_t i, num_extensions, num_controls;
>      LDAP *ld;
>
>      ld =3D self ? self->ldap : NULL;
> ----------------------------------------------------------------------=20=

> ---
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to =20
> share your
> opinions on IT & business topics through brief surveys -- and earn =20
> cash
> http://www.techsay.com/default.php?=20
> page=3Djoin.php&p=3Dsourceforge&CID=3DDEVDEV____________________________=
____=20
> _______________
> Python-LDAP-dev mailing list
> Pyt...@li...
> https://lists.sourceforge.net/lists/listinfo/python-ldap-dev

Compability issues with Python 2.5

[<mi...@st...>]

HI!

I suspect that python-ldap has some issues regarding changes in the C
API of Python 2.5. web2ldap with recent python-ldap crashes quite often.

Since my C knowledge is quite bad I need some volunteers. Anyone willing
to spend some spare time digging under Modules/ is encouraged to read
PEP 0353 and "What's New in Python 2.5":

http://docs.python.org/dev/whatsnew/ports.html

http://docs.python.org/dev/whatsnew/section-other.html (last two items
starting with "C API:")

http://www.python.org/dev/peps/pep-0353/#conversion-guidelines

I've attached a unified patch of my first try to address these issues.
But I won't commit them now. Please review.

Ciao, Michael.

Re: [PATCH] modlist.py: Compare old and new values

[<mi...@st...>]

Bhuvaneswaran Arumugam wrote:
> 
> Yep. After i went through test_modlist.py cases, i observed it was
> because i don't use list as the value of ldap key/variable.

So everything's ok with ldap.modlist.modifyModlist()?

Ciao, Michael.

Re: [PATCH] modlist.py: Compare old and new values

[Bhuvaneswaran A. <bh...@co...>]

Thanks for your response. Please find my comments and a patch for
test_modlist.py script.

On Wed, 2006-09-13 at 10:20 +0200, Michael Ströder wrote:
> Bhuvaneswaran Arumugam wrote:
> > 
> > BUG:
> > 
> > Currently you compare the length of old and new values.
> 
> Judging from your patch you mean the attribute value lists.

Yep. After i went through test_modlist.py cases, i observed it was
because i don't use list as the value of ldap key/variable. Please find
attached a patch to test_modlist.py script. I've included two test cases
viz. 'case 2' (list) and 'case 3' (string). 'case 2' is ok but 'case 3'
reports following error:

<error>

Testing function addModlist():

Testing function modifyModlist():
result_modlist is empty '[]'
modifyModlist({'nisMapEntry':
'-intr,hard,tcp,rsize=32768,wsize=32768,nfsvers=3
mgr:/u1/chroot//test/grue'},{'nisMapEntry':
'-intr,hard,tcp,rsize=32768,wsize=32768,nfsvers=3
mgr:/u1/chroot//test/mrue'}) returns
[]
instead of
[(0, 'nisMapEntry', '-intr,hard,tcp,rsize=32768,wsize=32768,nfsvers=3
mgr:/u1/chroot//test/mrue'), (1, 'nisMapEntry', None)].
</error>

But i'm unsure whether it's the intended behavior.

> > So, it does not
> > recognize the diff when there is no change in length but the actual
> > string itself is changed (ex: s/usr/var/g).
> 
> It's not that easy. replace_attr_value can also be set to 1 after line
> 87. Could you please post an example of the error?
> 
> Best thing would be to add your errornous case as test-case to
> Tests/Lib/ldap/test_modlist.py.
> 
> > Due to this bug, it returns
> > empty ldif so subsequent call to modify_s (in my application) fails.
> 
> Hmm, are you using module ldif afterwards to turn the modlist into LDIF?
> How does the modlist look like. Is it empty?
> 
> > <       replace_attr_value = len(old_value)!=len(new_value)
> > ---
> > 
> >>      replace_attr_value = old_value!=new_value
> 
> Please note that old_value and new_value are actually lists of attribute
> values. This line above sets only a first indicator that an attribute
> has changed to avoid performance loss due to calling the function
> list_dict().
> 
> Ciao, Michael.
> 
-- 
Regards,
Bhuvaneswaran

Re: [PATCH] modlist.py: Compare old and new values

[<mi...@st...>]

Bhuvaneswaran Arumugam wrote:
> 
> BUG:
> 
> Currently you compare the length of old and new values.

Judging from your patch you mean the attribute value lists.

> So, it does not
> recognize the diff when there is no change in length but the actual
> string itself is changed (ex: s/usr/var/g).

It's not that easy. replace_attr_value can also be set to 1 after line
87. Could you please post an example of the error?

Best thing would be to add your errornous case as test-case to
Tests/Lib/ldap/test_modlist.py.

> Due to this bug, it returns
> empty ldif so subsequent call to modify_s (in my application) fails.

Hmm, are you using module ldif afterwards to turn the modlist into LDIF?
How does the modlist look like. Is it empty?

> <       replace_attr_value = len(old_value)!=len(new_value)
> ---
> 
>>      replace_attr_value = old_value!=new_value

Please note that old_value and new_value are actually lists of attribute
values. This line above sets only a first indicator that an attribute
has changed to avoid performance loss due to calling the function
list_dict().

Ciao, Michael.

[PATCH] modlist.py: Compare old and new values

[Bhuvaneswaran A. <bh...@co...>]

Hello,

BUG:

Currently you compare the length of old and new values. So, it does not
recognize the diff when there is no change in length but the actual
string itself is changed (ex: s/usr/var/g). Due to this bug, it returns
empty ldif so subsequent call to modify_s (in my application) fails.

FIX:

Please find attached the patch.
[[
Patch by: Bhuvaneswaran Arumugam <bh...@co...>
Lib/ldap/modlist.py:
  * (modifyModlist): Compare the old and new value instead of their
    length. When it is compared against the length, it returns empty
    ldif even though there is difference between old and new value but
    not in length.
]]
-- 
Regards,
Bhuvaneswaran

Experimental 2.2.0 Windows Build

[Sidnei da S. <dre...@us...>]

Hello there,

I've managed to put together an experimental 2.2.0 build for Windows,
which can be found here:

  http://awkly.org/files/python-ldap-2.2.0.win32-py2.4.exe

I'm admittedly not an expert in compiling stuff, so if anyone with
more expertise can double-check what I've did:

  http://awkly.org/archive/compiling-python-extensions-on-mingw/


... specially the change from '-shared' to '-mdll -static' on the
arguments to 'ld', I would really *really* appreciate.

For the brave folks willing to try out the installer itself, you're at
your own risk, but please report back any issues.

If the build turns out to work fine and people are willing to bless
this as the official Windows build and upload it to sourceforge I
would be more than glad.

It was built with mingw against:

  openldap-2.2.29
  openssl-0.9.8b

-- 
Sidnei da Silva
Enfold Systems                http://enfoldsystems.com
Fax +1 832 201 8856     Office +1 713 942 2377 Ext 214

Re: self.__block.acquire(blocking) hanging Plone instance using LDAP

[<mi...@st...>]

Troy Davis wrote:
> 
> I've been trying to resolve a deadlock situation on a Plone instance  
> that uses ldap for authentication, and thus python-ldap. The ldap  
> server is on a Fedora Core 2 machine, openldap-servers-2.1.29-1 rpm.  

If ancient 2.1.29 is also the version of the OpenLDAP client libs I'd
strongly recommend to upgrade. There have been countless fixes to
libldap and libldap_r (recommended for multi-threaded apps).

You also won't get support for this old OpenLDAP version on the OpenLDAP
mailing lists (except recommendation to upgrade).

Ciao, Michael.