Re: [PATCH] Plug two leaks in python-ldap

[Xin LI <de...@de...>]

Hi, Michael,

=E5=9C=A8 2006-04-04=E4=BA=8C=E7=9A=84 12:16 +0200=EF=BC=8CMichael Str=C3=
=B6der=E5=86=99=E9=81=93=EF=BC=9A
> Thanks for submitting the patch.
> Do you have Python code demonstrating the leak?

By searching a non-existent entry DN from LDAP server, it would end up
with the error path and got the leak.

> Do you add the ldap_msgfree(msg) because LDAPmessage_to_python() is not
> called in these error cases?

Yes.  It takes me some minutes to figure out that the ldap message was
actually free'ed by LDAPmessage_to_python() in the usual path :-)

> > BTW.  Is there any plan to release a new version soon?
>=20
> I could release a new version very soon. (Despite that SF sucks and
> again I can't contact the CVS repository via SSH at the moment.)
>=20
> Note that as already stated in CVS version of CHANGES upcoming
> python-ldap 2.2.0 will require OpenLDAP libs 2.2.x or later for the build=
.

Glad to hear that :-)  Thanks!

Cheers,
--=20
Xin LI <delphij delphij net>    http://www.delphij.net/