Re: SASL (part 3)

[Jacek K. <ja...@bn...>]

On Tue, Mar 26, 2002 at 02:34:49PM +0100, Hans Aschauer wrote:
> Jacek,
> 
> > Seems very nice. I hope it will be soon commited to CVS, as we really
> > need SASL support.
> 
> I am not sure if this should be commited before 2.0. You know, this is 
> first time I do something SASL related, and first time that I hack 
> python-C bindings. 
The SASL code doesn't seem to break anything else. It an be IMHO marked
as "experimental" even in official release if required. But I think it's
Michael who should decide. He did most of the work recently, so he is
the boss here :-) And the stable and working relase of python-ldap is
also a think we need very much.

> However, if you think it should go into 2.0, it is 
> fine for me and I will try my best ;-) Anyway: how would I get write 
> access to CVS? 
Ask Michael.

> > But there are some things, that should be fixed:
> >
> > - it seems comments about SASL support in LDAPObject.c are outdated
> >   they still describe "callback-function" interface
> >
> > - I found now way to set realm for my bind so I wasn't able to bind
> > to my server. Realms are important feature of SASL, so there should
> > be an easy way to set them. Probably as another optional argument to
> > sasl_digest_md5
This is not true. CB_GETREALM works as it should. I don't know why it
didn't worked for me the first time I tried this.

> > - SASL_CB_... constants should probably be defined in constants.c
> > file, as other constants. The only problem is that these constants
> > are sasl-related, not ldap-related, but I cannot think about any
> > better place. When implemented them in C they are defined from the
> > good source: C header files
> >
> > - classes sasl... should be moved out of the demo to ldap package,
> > maybe to separate module
> 
> I think that I will have a few hours mid next-week in order to 
> fix/change/modify these things. Thanks!

Great :-)

Greets,
        Jacek

PS.
  I Cc to the list and didn't cut quotes, because these are parts of my
original message, which was intended to go here, but by my mistake it
was only sent to Hans.