Re: Stripped LDAPObject.c

[David L. <dav...@it...>]

hmmm, i'm not sure if i am completely comfortable with this

are the removed foo_s() functions really handled in the underlying library =
as a
call to foo() followed by ldap_result()?

i note you left in simple_bind_s() probably because from my reading of
the openldap source code, it shows that some complicated things happen at
the end of it that don't happen in simple_bind() ... i had a quick
skim and couldn't see the others doing much more ...

however, i do see how having a python-level wrapper is a good thing
(allows subclassing, locks, custom tracing)

d

On Fri, 21 Dec 2001, Michael Str=F6der typed thusly:

> HI!
>
> I've stripped all *_doc strings and almost all *_s() methods from
> LDAPObject.c. Also removed the deprecated Kerberos stuff completely.
>
> _ldap.so was 14kB smaller on my system (comparison after invoking
> strip). I also believe that it will be far easier to maintain the
> module now since there's not so much code subject to e.g. memory
> leaks etc. anymore.
>
> I did not check it in so far although it seems to work for me.
> Please check the attached C source and give feedback. Especially
> review and test the rename() and url_search() methods.
>
> For using all the *_s() methods you will need module
> Lib/ldap/ldapobject.py. So make sure your CVS tree is up-to-date.
>
> Ciao, Michael.

--=20
David Leonard                           Dav...@it...
Dept of Inf. Tech. and Elec. Engg   _   Ph:+61 404 844 850
The University of Queensland       |+|  http://www.itee.uq.edu.au/~leonard/
QLD 4072  AUSTRALIA               ~` '~ B73CD65FBEF4C089B79A8EBADF1A932F13E=
A0FC8