[Python-cgns-main] Python-bindings for CGNS library : minor changes

[Lionel G. <Lio...@fl...>]

Dear Oliver

I've just found some time to have a look at the git deposit at sourceforge.

I've been able to download the files on my machine and recompile rpms
for RHEL5. I would have a few remarks about the latest modifications
you made on the project :

1) About the version name. I don't know many applications having the
date as a version number. Wouldn't you like to set the version number
to a numbered version like "0.3" (I changed it to 0.2 before) instead
of '2011.02.09' ?

2) Concerning the installation directory in /usr/share/doc, I would prefer
if we could call it "python-cgns" instead of "pythoncgns". This is to be
coherent with all other products that you can find there. They are all
called "python-something".

3) Concerning the license file named LICENSE, I would like to have it
deployed in the installed directories. This is necessary when you build
binary packages like rpms. An end user will just install the binary rpm
and he thus needs to have the LICENSE file in the install somewhere.

As a conclusion, I would propose the following modifications :

diff -r python-cgns/setup.py python-cgns-0.3/setup.py
32c32
< Version = '2011.02.09'
---
 > Version = '0.3'
49c49,50
<     data_files =     [('share/doc/pythoncgns-'+Version+'/examples', 
['tutorial/boite_CGNSADF.pgeo',
---
 >     data_files =     [('share/doc/python-cgns-'+Version+'/', 
['LICENSE']),
 >              ('share/doc/python-cgns-'+Version+'/examples', 
['tutorial/boite_CGNSADF.pgeo',



Last point : did you manage to use the package on your system ?
As I said in a former email, you need to run the different commands
in the %build section of the spec file to compile the application.

Best regards,

Lionel