From: Francesc A. <fa...@ca...> - 2005-05-11 13:10:45
|
Antonio, I've uploaded your patch for dealing multidimensional attributes in the SVN repository. I've modified it a bit so that: =2D When you save python scalars, they become saved as HDF5 scalars (before, they were saved as arrays of shape (1,)), which is wrong IMO. =2D When you save numarray scalars, they become saved as HDF5 scalars as well. I'm hesitating here because I wonder myself whether saving them as a pickle would be better. I really prefer the implemented solution but, what do you think about? =2D For keeping backward compatibility, I added code so that for old PyTables files so that an HDF5 attribute with shape (1,) will be mapped to a Python scalar. With that I think all the requirements for multidimensional attributes are fulfilled (except perhaps how to serialize numarray scalars on disk). Wait until a snapshot will be made this midnight in the carabos repository of pytables in order to have a try at final code. I'll look into your second patch when I have more time (I'm a bit busy lately :-/). Thanks for it anyway! Ciao, =46rancesc A Dimarts 10 Maig 2005 23:55, Antonio Valentino va escriure: > Il giorno mar, 10-05-2005 alle 14:08 +0200, Francesc Altet ha scritto: > > Hola Antonio, > > > > Sorry for the late response, but I was very busy lately (PyTables 1.0 > > was the responsible of that ;) > > > > A Dijous 05 Maig 2005 22:37, Antonio Valentino va escriure: > > > Hi Francesc, > > > the problem on scalar values seems to be fixed now. > > > In the new patch is included your test suite with some changes. > > > Let me know if it is good for you. > > > > Thanks. It seems cleaner to me indeed. Unfortunately, the patch does > > not apply well against PyTables 1.0. Could you make the necessary > > modifications to this? > > Hi Francesc, > I have just uploaded the mdattr patch against PyTables 1.0. > > I also submitted a new patch that should provide a whider support for > chunked layout datasets. > Please take a look and let me know what do you think about. > > ciao > > [...] > > > Cheers, =2D-=20 >0,0< Francesc Altet =A0 =A0 http://www.carabos.com/ V V C=E1rabos Coop. V. =A0=A0Enjoy Data "-" |