Re: [Pyst-users] a comment...

[Stephen C. <ste...@u4...>]

Hi Jan,

I would gladly use it, as far review goes, I think I'm too new to 
asterisk for that.

Cheers,

Stephen

Jan Müller wrote:
> hi,
>
> triggered by the recent mailing list activities, i just began to scan 
> the code of manager.py, and i found this:
>
>     def event_dispatch(self):
>         """This thread is responsible fore dispatching events"""
>
>         # loop dispatching events
>         while self._running.isSet():
>             # get/wait for an event
>             ev = self._event_queue.get()
>
>             # if we got None as an event, we are finished
>             if not ev:
>                 break
>
>             # dispatch our events
>
>             # first build a list of the functions to execute
>             callbacks = self._event_callbacks.get(ev.name, [])
>             callbacks.extend(self._event_callbacks.get('*', []))  # <- !!!
>
>             # now execute the functions
>             for callback in callbacks:
>                if callback(ev, self):
>                   break
>
> what happens here is that the '*' callback handlers are explicitly added 
> to the (mutable) list of ev.name handlers.
> i haven't tried it but this should lead to problems when unsubscribing a 
> '*' handler since it still remains an
> ev.name handler. i suggest a list addition to prevent manipulation of 
> the list of ev.name handlers:
>
> [...]
>             # first build a list of the functions to execute
>             callbacks = self._event_callbacks.get(ev.name, []) + 
> self._event_callbacks.get('*', [])
> [...]
>
> when i find time (might take a while), i might try and implement some 
> more of the API in the Manager class for myself.
>
> for instance, for an event/callback driven command 'Action: sippeers', i 
> would implement a method that yields a set of the 'Event: PeerEntry' 
> Events to spare a user the trouble of (un)subscribing a callback, making 
> up ActionIds, etc.
>
> anyone besides me interested in this, both using and reviewing it?
>
> regards, Jan
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> Pyst-users mailing list
> Pys...@li...
> https://lists.sourceforge.net/lists/listinfo/pyst-users
>