#11 Simplify ber decode method

closed-accepted
None
5
2004-04-13
2004-04-10
No

This patch *should* have the effect of a minor speed up
in the decode method (the envelope length-decoding
method). However, the real-world speedup is minimal in
my tests. What it does do is simplify the code
somewhat while generalising it ever so slightly (to
allow for length strings of any length that can be
specified by the format). There's also a few notes
about where there might be a few more operations that
could be eliminated.

Profiling is showing this method to be the current
hotspot (~5% total time (~19% cummulative)).

Discussion

  • Ilya Etingof

    Ilya Etingof - 2004-04-13

    Logged In: YES
    user_id=106050

    Regarding your comment in the source -- if I'm reading BER
    spec correctly, 'EXPLICIT'ly tagged subtypes would produce a
    sequence of BER tags in the wire. Please, let me know otherwise.

     
  • Ilya Etingof

    Ilya Etingof - 2004-04-13
    • assigned_to: nobody --> elie
    • status: open --> closed-accepted
     
  • Ilya Etingof

    Ilya Etingof - 2004-04-13

    Logged In: YES
    user_id=106050

    BTW, I've merged the 3.x.x CVS branch with the trunk (and
    committed some significant changes to the rest of the code)
    so you'd need to checkout the main pysnmp branch (e.g. w/o
    tag).

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks