Re: [Pysnmp-dev] possible bug in SnmpV1SecurityModel.processIncomingMsg ?
Brought to you by:
elie
From: Ilya E. <il...@gl...> - 2008-08-03 20:29:16
|
Your fix is absolutely correct. I've just committed it into CVS at SourceForge. Thanks for pointing out! -ilya [ skipped ] > There is a while(1) look in there that is exited with a break when the > incoming communityName is matched against an entry in the SNMP-COMMUNITY-MIB > snmpCommunityName or we exhaust all the snmpCommunityName entries without > finding a match, in which case the request should be dropped and > snmpInBadCommunityNames incremented. > > The problem is we always seem to allow in the user, even when a match is not > found. The problem is that the 'else' clause outside of the while(1) loop > can never be entered since the else clause on a loop is only entered when > the loop terminates normally, which is impossible for a while(1) loop. [ skipped ] |