[pysnmp-users] Where to do diffs for fixes/enhancements?
Brought to you by:
elie
From: Mike C. F. <mcf...@ro...> - 2004-02-14 11:45:56
|
A list for users of pure-Python SNMP framework <pysnmp-users.lists.sourceforge.net> List-Post: <mailto:pys...@li...> List-Help: <mailto:pys...@li...?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/pysnmp-users>, <mailto:pys...@li...?subject=subscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=pysnmp-users> I've just done a bit of optimising the _subtype_constraint method and breaking the constraint-checking code into its own classes & module to make creating an accelerator in C easier. Even without the accelerator module, these changes take the _subtype_constraint method from 7.9/10.5% of load down to 2.6/7.4% of total load under the TwistedSNMP test suite (that's still 14s of 191s, btw). The two methods ValueSizeConstraint.__call__ and ValueRangeConstraint.__call__ each take 2.6% of total cumulative time. They are incredibly simple functions (and are basically identical, save for whether they operate on the value or len(value)), so rewriting in C should give a decent boost for very minimal work. Note: the new code does *not* do the checks for _subtype_single_value_constraint and the like. Basically, if a constraint object is present it is considered allowed. I would put those checks in a meta-class initialiser, but figuring out the whole class hierarchy to do so is a bit daunting. Anyway, the question is, how do we go about collaborating, particularly submitting the patches? Do we want to use the SourceForge project's patch-manager for such things? Or just directly email Ilya? Or do something else? Have fun all, Mike _______________________________________ Mike C. Fletcher Designer, VR Plumber, Coder http://members.rogers.com/mcfletch/ |