From: Ludovic R. <lud...@gm...> - 2015-06-20 11:24:36
|
2015-06-20 2:07 GMT+02:00 Alex Willmer <al...@mo...>: > Ludovic, Hello, > Thank you for merging my changes. I see also that you've started a > Python 3 branch. The C code is outside my expertise, but you should be > aware of one behaviour change that [1abd4d] introduced > > - print reader.name, ', uri: ', reader.uri > + print(reader.name, ', uri: ', reader.uri) > > In 2.x this will print the repr() of a tuple, not the string you intended. e.g. > [GCC 4.9.2] on linux2 > Type "help", "copyright", "credits" or "license" for more information. >>>> print 'a', 'b', 'c' > a b c >>>> print('a', 'b', 'c') > ('a', 'b', 'c') > > The fix is >>>> from __future__ import print_function >>>> print('a', 'b', 'c') > a b c I know. I don't know if the pyscard should move to Python3 only or continue to support Python2 as well. It is easy to support both Python 2 and Python 3? > One final thing, I'm experimenting with hosted builds and continuous > integration on Windows. It looks like we can get 32 and 64 bit Windows > binaries/installers for pyscard with very little trouble. > > Repo: https://github.com/moreati/pyscard * > 1st build: https://ci.appveyor.com/project/moreati/pyscard/build/1.0.4/job/7jeh37mcn85ey8tr Great. I did not know ci.appveyor.com, only https://travis-ci.org/ It looks like appveyor is for Windows only and travis is for Linux and Mac only. > * Github was just convenient, I've no intention of forking pyscard and > I will be sending patches to you. You should have cloned my github repository https://github.com/LudovicRousseau/pyscard. It would be easier to make pull requests. Bye -- Dr. Ludovic Rousseau |