[Pyscard-devel] [ pyscard-Feature Requests-3110077 ] new style classes

[SourceForge.net <no...@so...>]

Feature Requests item #3110077, was opened at 2010-11-16 13:10
Message generated for change (Settings changed) made by ludov
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=957075&aid=3110077&group_id=196342

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface Improvements (example)
Group: Next Release (example)
>Status: Open
Priority: 5
Private: No
Submitted By: chrysn ()
Assigned to: jean-daniel aussel (jdaussel)
Summary: new style classes

Initial Comment:
since version 2.2, python has "new style classes", which unify types and classes. they provide more flexibility for getters and setters and better support for the super call, among other features.

i suggest to change pyscard classes into new style classes by changing the definitions from "class Observer:" to "class Observer(object):". the classes this affects can be found using `grep '^class .*[^)]:' . -r`.

(by the way, that list includes SWException, which i assume from the name should derive from Exception.)

----------------------------------------------------------------------

Comment By: Ludovic Rousseau (ludov)
Date: 2011-10-19 14:50

Message:
Partly reverted in revision 572. Maybe you can help solve the problem.

The error is:
  File "/Library/Python/2.7/site-packages/smartcard/__init__.py", line 34,
in <module>
    from smartcard.System import listReaders
  File "/Library/Python/2.7/site-packages/smartcard/System.py", line 27,
in <module>
    import smartcard.reader.ReaderFactory
  File
"/Library/Python/2.7/site-packages/smartcard/reader/ReaderFactory.py", line
34, in <module>
    from smartcard.pcsc.PCSCReader import PCSCReader
  File "/Library/Python/2.7/site-packages/smartcard/pcsc/PCSCReader.py",
line 25, in <module>
    from smartcard.CardConnectionDecorator import CardConnectionDecorator
  File
"/Library/Python/2.7/site-packages/smartcard/CardConnectionDecorator.py",
line 27, in <module>
    from smartcard.CardConnection import CardConnection
  File "/Library/Python/2.7/site-packages/smartcard/CardConnection.py",
line 28, in <module>
    from smartcard.Observer import Observer
  File "/Library/Python/2.7/site-packages/smartcard/Observer.py", line 81,
in <module>
    "countObservers")
  File "/Library/Python/2.7/site-packages/smartcard/Synchronization.py",
line 36, in synchronize
    klass.__dict__[name] = synchronized(val)
TypeError: 'dictproxy' object does not support item assignment

----------------------------------------------------------------------

Comment By: Ludovic Rousseau (ludov)
Date: 2011-10-19 14:26

Message:
This is now fixed in revision 571
http://pyscard.svn.sourceforge.net/viewvc/pyscard?view=revision&revision=571

Thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=957075&aid=3110077&group_id=196342