[Pyre2-devel] Re: changes to re2 library
Status: Beta
Brought to you by:
ottrey
From: <ot...@py...> - 2005-04-11 08:32:58
|
Hi Pierre, On 4/8/2005, "Pierre Barbier de Reuille" <pie...@ci...> wrote: >Here is the expression cuasing the bug : > >"(((?:\s*)(?P<num>\d+))+,)+\s*(?P<logic>[^ ]+)((?P<lastnum>\s*\d+)+)" > >.. you cannot compile it with re2 but you can do it with re ! I've eXtreme Program fixed that bug. ie spent ~minimal~ time thinking about and just blindly added a test case for it then made the code work for that test case aswell as all the other ones. ...sure it should be refactored at some stage, but at least the prototype is getting a good work out. ;-) Anyway, I've checked the fix in to the subversion repository (Rev 24). http://pintje.servebeer.com/svn/pyre2/trunk/ Although I'm not ~quite~ sure the expected result for the test case I have created is correct. Would you be able to check it for me? And any other comments? (particularly on the interface) |