[Pypgsql-devel] [ pypgsql-Bugs-816729 ] 7.4beta

[SourceForge.net <no...@so...>]

Bugs item #816729, was opened at 2003-10-02 14:16
Message generated for change (Settings changed) made by ballie01
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=816729&group_id=16528

Category: None
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Submitted By: jeff putnam (jefu)
Assigned to: Billy G. Allie (ballie01)
Summary: 7.4beta

Initial Comment:
I'm trying to use this with postgresql 7.4beta3 and ran

into several

version related bugs (none seemed to really stem from

any sql

problems, that is).   



First I found  the same bug as bug number 786712.  My

fix was a bit different - I changed pgversion.c around

line 183 to : 



    /* Allow for alpha and beta versions */

    if (((*last == 'a')  || (*last == 'b')) &&

(isdigit(*(last+1)))) 

       return (errno != 0) ; 



    if (pgstricmp(last, "alpha") == 0) 

       return (errno != 0) ; 



    if (pgstricmp(last, "beta") == 0) 

	return (errno != 0);



I also think "Ivalid" should probably be "Invalid"  at

line 254. 



Once that was fixed there were a couple problems in the

test

code - all the following refer to PgSQLTestCases.py



On line 801, I get a failure to find the right version,

so ran the query

select count(*) from pg_class where relname like 'pg_%%' ; 

this returned 137 so I added '7.4':137 to the table there. 



In "CheckExecuteWithSingleton" I did the select there :

select * from pg_database  where datname = 'template1'

and got 11 colums so added a test around line 	620 :

elif self.vstr.startswith("7.4"):

	    flen = 11



There was another version connected error  :

======================================================================

FAIL: CheckPgVer (__main__.PgSQLTestCases)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "PgSQLTestCases.py", line 589, in CheckPgVer

    self.fail(msg)

  File "/usr/lib/python2.2/unittest.py", line 254, in fail

    raise self.failureException, msg

AssertionError: SELECT version() says 7.4beta3,

cnx.version says 7.4

 

--------------------------------------------------------------------



in psql :

select version() ; 

returns :

 PostgreSQL 7.4beta3 on i686-pc-linux-gnu, compiled by

GCC gcc (GCC) 3.2.2 20030222 (Red Hat Linux 3.2.2-5)

I wasn't sure quite how to fix that so set CheckPGVer

to succeed

always. 



Then the tests all seemed to work. 



----------------------------------------------------------------------

>Comment By: Billy G. Allie (ballie01)
Date: 2003-10-06 14:43

Message:
Logged In: YES 
user_id=8500

Thank you for the bug reports (and especially) the fixes.



Fixes for all but one of these bugs have been commited into

the CVS repository.

'

The CheckPgVer issue will not be fixed, since it only occurs

with alpha, beta, or release canidate versions.  It will

work when 7.4 final is released.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=816729&group_id=16528