[Pypgsql-devel] [ pypgsql-Bugs-2897405 ] PgConnection.flush fails to handle nonblocking writes

[SourceForge.net <no...@so...>]

Bugs item #2897405, was opened at 2009-11-13 14:15
Message generated for change (Tracker Item Submitted) made by edwardfaulkner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=2897405&group_id=16528

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Edward Faulkner (edwardfaulkner)
Assigned to: Nobody/Anonymous (nobody)
Summary: PgConnection.flush fails to handle nonblocking writes

Initial Comment:
PgConnection.flush appears to misunderstand how to use the underlying PQflush function.  When PQflush returns 1, this is not an error.  The 1 should be returned to the caller of PgConnection.flush, so the caller knows whether to call flush again.

1 means  "call again when the socket is writable."  
0 means "no more data to write".  
-1 means error, and only in this case should PgConnection.flush throw an exception.

This is necessary for any application that wants to write big statements in a nonblocking way.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=2897405&group_id=16528