[Pypgsql-users] [PATCH] Transaction problems with large objects in PgSQL.py

[Pinchart, L. <Pin...@PC...>]

Hi,

Here's a patch that fixes two transaction problems in PgSQL.py.

The first problem is in Connection.binary, which commits a transaction if it
has started one, but doesn't reset the "inTransaction" flag to 0. The
Connection object thus thinks that we are still in a transaction when we are
not, and fails to begin a new transaction on the next cursor open operation.

The second problem is in Connection.unlink which should raise a
NotSupportedError exception when a called from within a transaction in
PostgreSQL < 7.1.0. The version check actually raise an exception when the
PostgreSQL version is >= 7.1.0 OR when a transaction is NOT in progress,
instead of when the PostgreSQL version is NOT >= 7.1.0 AND a transaction is
in progress.

The attached patch is against the latest CVS version.

Laurent Pinchart