Re: [Pypes-developer] Reserved Attributes and Metadata Keywords for Packets

[Eric G. <eg...@py...>]

On Sep 20, 2009, at 3:08 PM, Matt Weber wrote:

> Attached is a patch that completely refactors the packet api to be  
> PEP-8 compliant.  I have also added unit tests for every single  
> method to ensure that it works 100% as expected.  During the  
> refactor, I removed some of the methods I felt were unnecessary due  
> to duplicated functionality.  For example I removed GetValue, and  
> moved its functionality into Get.  Why would we need a Get that  
> raises a KeyError, or a GetValue that returns a different value?  We  
> can always use GetValue and check for the default.  In FAST stages,  
> I never used anything but GetValue.  If you disagree, it will be  
> trivial to add these methods back.  Please review the patch and let  
> me know what you think before I start refactoring the components to  
> work with this api.

Agreed. Those methods are silly and should be removed.

-Eric