Re: [Pypentago-devel] Code styleguide

[Florian M. <flo...@ai...>]

Hardik Mehta wrote:
> Hi,
> 
> I think converting itself using regex is not a big deal, but in this process
> you may break something, e.g a similarly named variable and because we don't
> have unittest coverage, there is no guarantee that everything is working as
> it was before the style change.
> 
> I don't have much idea about the code in other modules than db, but if you
> think something may get broken after the style change you can develop unit
> tests to test those parts before the change and the tests should pass after
> the change. This is sort of a guarantee that you will not break anything.
> 
> regards,
> Hardik
I think unittest are a bit over the top as the current features are
easily testable by just playing a test game and watching for exceptions.

Florian Mayer