Re: [Pypentago-devel] Questions about db structure

[Hardik M. <har...@gm...>]

>
> Good question.
> I was going to assume that the winner of the game was always p1.
> But I think I like your direction better.  A new field for "winner_id" or
> something?


Hi the idea of p1_id being the winner_id is good, saves a field but what
about the condition when it is a draw ?

So I added the winner_id in a way that it will be p1_id  or p2_id or
None(empty) in case of a draw. I think you will agree with this.

Now I have some other questions about the GameHistory table.

I think that the rating, RD and volatility of both the players you store in
GameHistory table are the values at the time of creation of the GameHistory
e.g. when they were playing the game. They will not change with the player's
current rating, RD and volatility.

Am I right ?

And yes, there will be Foreign keys p1_id and p2_id and also the winner_id.







>
>
>
> > 3. I added real_name to the Player structure instead of adding firstname
>
> Sounds good!
>
>
>
> > 4. Are we not going to need an Email id for the registration process ? If
> > yes, should I add it ?
>
> Yes, yes!
>
>
> (We have not actually discussed this, but maybe we just all assumed email
> address would be in there.)
>
> In fact, maybe we should look at another open source DB structure and make
> sure we aren't forgetting other fields needed in the Players table.
>
> A "player_avatar" image blob also sounds potentially useful...
>
> Thanks,
>
> Kovacs
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>