From: M.-A. L. <ma...@eg...> - 2009-03-16 21:03:16
|
There's a patch available for pyOpenSSL which appears to be originating from an older pyOpenSSL branch started by Dave Cridland: http://sourceforge.net/tracker/index.php?func=detail&aid=2591835&group_id=31249&atid=401760 This is the SVN repo of Dave's branch: http://trac.dave.cridland.net/cgi-bin/trac.cgi/browser/projects/pyopenssl The patch mentions these authors: +# Copyright 2006 Dave Cridland. See COPYING for rights +# Copyright 2006 Arnaud Desmons +# Copyright 2005 Keyphrene Keyphrene contributed the wrappers for the EVP APIs (high level interface to ciphers, hashes, digests, etc). Dave Cridland has extended the SSL part of pyOpenSSL. Arnaud Desmons is not mentioned anywhere in the patch, so it's not clear what he contributed, but he appears in the Keyphrene patch for the first time: http://trac.dave.cridland.net/cgi-bin/trac.cgi/changeset/696 The license on the patch is LGPL 2.1, just like for pyOpenSSL itself. Any chance of getting at least part of this merged into pyOpenSSL ? Thanks, -- Marc-Andre Lemburg eGenix.com Professional Python Services directly from the Source (#1, Mar 16 2009) >>> Python/Zope Consulting and Support ... http://www.egenix.com/ >>> mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ >>> mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/ ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ |
From: Dave C. <da...@cr...> - 2009-03-16 22:47:31
|
On Mon Mar 16 21:02:53 2009, M.-A. Lemburg wrote: > There's a patch available for pyOpenSSL which appears to be > originating > from an older pyOpenSSL branch started by Dave Cridland: > > http://sourceforge.net/tracker/index.php?func=detail&aid=2591835&group_id=31249&atid=401760 > > Other way around, I applied it on my fork. Actually, quite a lot of stuff is not mine, the only bits that are are a few additional API points in the Connection object, and most importantly the ability to pass in non-socket, Python file protocol objects. > This is the SVN repo of Dave's branch: > > http://trac.dave.cridland.net/cgi-bin/trac.cgi/browser/projects/pyopenssl > > The patch mentions these authors: > > +# Copyright 2006 Dave Cridland. See COPYING for rights Tick. Although more properly 2006-2007 > +# Copyright 2006 Arnaud Desmons Indeed... > +# Copyright 2005 Keyphrene I applied this patch in 2006 (in two commits, because I fu... didn't quite get things right). I'm not strictly sure, therefore, that this date is right without going back. > Keyphrene contributed the wrappers for the EVP APIs (high level > interface > to ciphers, hashes, digests, etc). > > Yup. Revs 696 and 697. > Dave Cridland has extended the SSL part of pyOpenSSL. > > Yup. Basically rev 683, plus a bunch of stuff to fix bugs I put in that, plus 755 (which is sessions, and largely untested in anger). > Arnaud Desmons is not mentioned anywhere in the patch, so it's not > clear what he contributed, but he appears in the Keyphrene patch for > the first time: > > http://trac.dave.cridland.net/cgi-bin/trac.cgi/changeset/696 > > Yes, because he hadn't added himself in, and I noticed only then. His patch is 695. Keyphrene.com's work was published on their website, I merely noticed it and incorporated it into my code for the convenience of having all these patches in one place. Arnaud's patch was sent to this list. > The license on the patch is LGPL 2.1, just like for pyOpenSSL > itself. > > For my changes, I'll BSD, or whatever else people want. I'm not a particular fan of this work being LGPL in the first place, but it's all too late to change now. > Any chance of getting at least part of this merged into pyOpenSSL ? It'd be nice - I still use this fork, actually, mainly out of lethargy - but it mostly dates from a time when I needed to do byte-counting on TLS sessions, and all sorts, as part of my work. I don't have such a pressing need now. If there's interest in the code, I'll cheerfully rebase it onto the current tree. Hmmm, I came over all git then, but you know what I mean. Dave. -- Dave Cridland - mailto:da...@cr... - xmpp:dw...@da... - acap://acap.dave.cridland.net/byowner/user/dwd/bookmarks/ - http://dave.cridland.net/ Infotrope Polymer - ACAP, IMAP, ESMTP, and Lemonade |
From: M.-A. L. <ma...@eg...> - 2009-03-19 10:38:09
|
On 2009-03-16 23:35, Dave Cridland wrote: > On Mon Mar 16 21:02:53 2009, M.-A. Lemburg wrote: >> There's a patch available for pyOpenSSL which appears to be >> originating >> from an older pyOpenSSL branch started by Dave Cridland: >> >> http://sourceforge.net/tracker/index.php?func=detail&aid=2591835&group_id=31249&atid=401760 >> >> > Other way around, I applied it on my fork. > > Actually, quite a lot of stuff is not mine, the only bits that are > are a few additional API points in the Connection object, and most > importantly the ability to pass in non-socket, Python file protocol > objects. > > [snip] > >> The license on the patch is LGPL 2.1, just like for pyOpenSSL >> itself. >> >> > For my changes, I'll BSD, or whatever else people want. I'm not a > particular fan of this work being LGPL in the first place, but it's > all too late to change now. > > >> Any chance of getting at least part of this merged into pyOpenSSL ? > > It'd be nice - I still use this fork, actually, mainly out of > lethargy - but it mostly dates from a time when I needed to do > byte-counting on TLS sessions, and all sorts, as part of my work. I > don't have such a pressing need now. > > If there's interest in the code, I'll cheerfully rebase it onto the > current tree. Thanks for the detailed explanation of where the new code originated. I think that's important to have if the patch should end up in the main pyOpenSSL distribution. I think there is a lot of useful stuff in the patch. I'd especially be interested in the EVP work done by Keyphrene.com since currently the only way access those APIs in Python appears to be M2Crypto with its long history of memory leaks and reference count bugs (not sure what todays situation is like, but a few years ago, it was a minefield). By contrast, pyOpenSSL has demonstrated to be a really stable platform to work with, so if those EVP patches are of the same quality, we'd much rather like to use those. -- Marc-Andre Lemburg eGenix.com Professional Python Services directly from the Source (#1, Mar 19 2009) >>> Python/Zope Consulting and Support ... http://www.egenix.com/ >>> mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ >>> mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/ ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ |
From: Dave C. <da...@cr...> - 2009-03-19 11:07:22
|
On Thu Mar 19 10:37:56 2009, M.-A. Lemburg wrote: > Thanks for the detailed explanation of where the new code > originated. > I think that's important to have if the patch should end up in the > main pyOpenSSL distribution. > > Certainly. > I think there is a lot of useful stuff in the patch. I'd especially > be interested in the EVP work done by Keyphrene.com since currently > the only way access those APIs in Python appears to be M2Crypto with > its long history of memory leaks and reference count bugs (not sure > what todays situation is like, but a few years ago, it was a > minefield). > > Keyphrene.com's code I think I merged by diffing their "Org.keyphrene" package. You do have to dig down quite a bit, sadly, to find out it's the same codebase underneath, merged with various other projects. Close examination reveals it includes "mxTidy", for instance, although the copyright notice is only presevred in the mxTidy.c file. (I assume it *is* compatible with LGPL, right?) Dave. -- Dave Cridland - mailto:da...@cr... - xmpp:dw...@da... - acap://acap.dave.cridland.net/byowner/user/dwd/bookmarks/ - http://dave.cridland.net/ Infotrope Polymer - ACAP, IMAP, ESMTP, and Lemonade |
From: M.-A. L. <ma...@eg...> - 2009-03-19 11:58:59
|
On 2009-03-19 12:07, Dave Cridland wrote: > On Thu Mar 19 10:37:56 2009, M.-A. Lemburg wrote: > Keyphrene.com's code I think I merged by diffing their "Org.keyphrene" > package. You do have to dig down quite a bit, sadly, to find out it's > the same codebase underneath, merged with various other projects. They do appear to provide a separate download for this as well: http://www.keyphrene.com/products/pyOpenSSL-extended/index.php?lng=en > Close examination reveals it includes "mxTidy", for instance, although > the copyright notice is only presevred in the mxTidy.c file. (I assume > it *is* compatible with LGPL, right?) mxTidy is under the eGenix Public License (a Python style license), the original HTML Tidy under a BSD-style license. Both are compatible with the LGPL, AFAIK. However, they also both require that the licenses be kept with the source code. If that's not the case, then they are in violation of the licenses. Looking at their archive http://www.keyphrene.com/products/org.keyphrene/?lng=en they don't provide any license or documentation files whatsoever, so I guess we need to have a friendly word with them :-) -- Marc-Andre Lemburg eGenix.com Professional Python Services directly from the Source (#1, Mar 19 2009) >>> Python/Zope Consulting and Support ... http://www.egenix.com/ >>> mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ >>> mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/ ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ |
From: M.-A. L. <ma...@eg...> - 2009-03-19 12:05:22
|
On 2009-03-19 12:58, M.-A. Lemburg wrote: > On 2009-03-19 12:07, Dave Cridland wrote: >> On Thu Mar 19 10:37:56 2009, M.-A. Lemburg wrote: >> Keyphrene.com's code I think I merged by diffing their "Org.keyphrene" >> package. You do have to dig down quite a bit, sadly, to find out it's >> the same codebase underneath, merged with various other projects. > > They do appear to provide a separate download for this as well: > > http://www.keyphrene.com/products/pyOpenSSL-extended/index.php?lng=en ... in addition to wrapping it up as "ssl4py": http://www.keyphrene.com/products/4py/index.php?lng=en without any notice about the origin of the software. >> Close examination reveals it includes "mxTidy", for instance, although >> the copyright notice is only presevred in the mxTidy.c file. (I assume >> it *is* compatible with LGPL, right?) > > mxTidy is under the eGenix Public License (a Python style license), > the original HTML Tidy under a BSD-style license. Both are compatible > with the LGPL, AFAIK. However, they also both require that the licenses > be kept with the source code. If that's not the case, then they are in > violation of the licenses. > > Looking at their archive > > http://www.keyphrene.com/products/org.keyphrene/?lng=en > > they don't provide any license or documentation files whatsoever, > so I guess we need to have a friendly word with them :-) -- Marc-Andre Lemburg eGenix.com Professional Python Services directly from the Source (#1, Mar 19 2009) >>> Python/Zope Consulting and Support ... http://www.egenix.com/ >>> mxODBC.Zope.Database.Adapter ... http://zope.egenix.com/ >>> mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/ ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ |