Re: [pyOpenSSL] CRL & PKCS12 patch

[Sebastian V. <seb...@gm...>]

Hi,

Is there any progress on this? I mean, will the CRL functionality be in the
next pyOpenSSL release and if so, when will that be? I'm trying to get a
python app into Fedora but while a part of its functionality is based on a
custom patched pyOpenSSL it will probably not be accepted.

Apart from that, it's of course a great feature for pyOpenSSL that will
benefit everyone :)

thanks,

S.

On Sat, Jul 18, 2009 at 3:55 AM, Jean-Paul Calderone <ex...@di...>wrote:

> On Mon, 13 Jul 2009 23:06:04 +0100, Phil Mayers <p.m...@im...>
> wrote:
> >> Looking at <https://code.launchpad.net/pyopenssl>, I see that there are
> >> presently four different branches related to either CRL or PKCS12.
> >>
> >>   lp:~exarkun/pyopenssl/pkcs12-crl
> >>   lp:~arnaud-desmons/pyopenssl/pkcs12
> >>   lp:~rick-fdd/pyopenssl/pkcs12_mod_and_export
> >>   lp:~sebvieira/pyopenssl/pkcs12-crl-0.8
> >
> >I believe at least 3 of those are actually the same patch; numbers 1 &
> >2, and 3 is a forward-port to 0.8
> >
> >My work was just a quick port (again) of the 0.8 branch to the 0.9
> >release code.
>
> Hm, if I'd had my head on straight, I would have pinged Rick (owner of
> branch number 3) and made sure he coordinated with you in this effort.
> Instead, I only just now realized that you and he have some PKCS12
> overlap in the work you're doing.
>
> Looking at his branch (not the one above though, he has since created
> a newer one with a "2" on the end) and yours, I think his PKCS12 code
> is more complete overall.  However, it could still benefit from some of
> the things your version does (you have better type checking code, I
> think).
>
> I'm going to point him at your work along with my other feedback.
>
> Once the PKCS12 stuff is out of the way, I'll dig into the CRL parts
> of your branch more (I've still only just skimmed them).
>
> There is currently a PKCS12 ticket, I see:
>
>  https://bugs.launchpad.net/pyopenssl/+bug/349304
>
> I also now see that there is a ticket which talks about CRLs!  The summary
> didn't make this obvious so I missed/forget about it.  It has a patch
> attached which I haven't looked at at all yet.  The ticket is
>
>  https://bugs.launchpad.net/pyopenssl/+bug/385178
>
> And to keep things interesting, it sounds like it mixes in a bunch of PKCS7
> changes.
>
> > [snip]
> >
> >Do you have C indent preferences?
> >
>
> I wish I did.  I think I'm leaning towards 4 space indents.  However, if
> you're modifying existing code, go with the local prevailing convention.
> I'm trying to keep things consistent, but I'm sure I'm failing at that in
> places.
>
> Apologies again for not pointing out those two tickets in my previous
> message.
>
> Jean-Paul
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> pyopenssl-list mailing list
> pyo...@li...
> https://lists.sourceforge.net/lists/listinfo/pyopenssl-list
>