Re: [pyOpenSSL] CRL & PKCS12 patch

[Phil M. <p.m...@im...>]

> Looking at <https://code.launchpad.net/pyopenssl>, I see that there are
> presently four different branches related to either CRL or PKCS12.
> 
>   lp:~exarkun/pyopenssl/pkcs12-crl
>   lp:~arnaud-desmons/pyopenssl/pkcs12
>   lp:~rick-fdd/pyopenssl/pkcs12_mod_and_export
>   lp:~sebvieira/pyopenssl/pkcs12-crl-0.8

I believe at least 3 of those are actually the same patch; numbers 1 & 
2, and 3 is a forward-port to 0.8

My work was just a quick port (again) of the 0.8 branch to the 0.9 
release code.

>   * File a ticket!  Right now it's not really clear what the goal of all
>     this work is.  It has something to do with "CRL" and "PKCS12" clearly,
>     but writing down something more specific than that will make it possible
>     to figure out what's going on, how the branches that exist related to it,
>     and whether or not the goal has been achieved.

Well, to be honest I'm much less interested in pkcs12 (though I can see 
it's useful) but I'll have a crack at two tickets.

> 
>   * Review the APIs for sensibleness and general-purposeness.  Do they
>     expose the underlying OpenSSL APIs in a way that's generally useful,
>     with introduced arbitrary limitations?  As someone who knows a bit
>     about CRLs and PKCS12 (I assume - since you wrote a CA ;), hopefully
>     this should be easy for you.

Hmm. To be honest, having spent several hours today fooling with BIO* 
and similar, I intensely dislike most of the OpenSSL APIs, so the less 
they reflect them... ;o)

But I take the point - a sensible, pythonic api.

> 
>   * Add unit tests for *all* new code and for any old code which is being
>     modified and is not already tested.
> 
>   * Add documentation for the new APIs (doc/pyOpenSSL.tex is the doc source,
>     the rest of the files in doc/ are generated).

Ack. Tex...

I've had a first go at the code; I've added a single test for the CRL.

https://code.launchpad.net/~phil-mayers/pyopenssl/crl+morepkcs12

I'm pretty sure it's not the best API layout, but I had a couple of 
hours free and wanted to get something basic working tonight; I'll try 
and write a ticket and think about the API tomorrow.

Do you have C indent preferences?