pyopengl-users

[PyOpenGL-Users] Code readability

[SAn <gri...@gm...>]

Hi! I am trying to understand pyopengl VBO implementation, well, the
whole OpenGL.array package.

Is there a reason why the code is written so "anti-pep8/python zen"
way? Like that there isn't a new line between class methods, etc.
Maybe because of consistence with the automatic generator?

I am editing the files manualy so i could read and undestand them,
from bzr. I could send you a patch, and maybe to the generator too!

thanks,
SAn

Re: [PyOpenGL-Users] Code readability

[Mike C. F. <mcf...@vr...>]

On 11-05-21 11:47 AM, SAn wrote:
> Hi! I am trying to understand pyopengl VBO implementation, well, the
> whole OpenGL.array package.
>
> Is there a reason why the code is written so "anti-pep8/python zen"
> way? Like that there isn't a new line between class methods, etc.
> Maybe because of consistence with the automatic generator?
Mostly because it is written by one crusty old pythonista who pre-dates
PEP-8 (heck, PEPs entirely) by a significant period, and who looks at
PEP-8 conformance as something those young whippersnappers do ;) :D . 
Be happy I finally gave in and started using spaces instead of tabs :)
.  It took a plea directly from Pete Shinners (or maybe it was René?
been a while) to get that to happen, and I felt dirty for months after.

I'm fine with accepting a pep-8 patch, but keep in mind that APIs should
not change, and I'm really not all that worried about keeping the
code-base PEP-8-ified moving forward... that is, I can't guarantee I
won't edit the files at some point and make them match my personal
preference again :) .  If I start seeing people contributing code
frequently I might revisit that opinion, but if it's still basically
just me, I'll likely just do as comes naturally.

Have fun,
Mike

-- 
________________________________________________
  Mike C. Fletcher
  Designer, VR Plumber, Coder
  http://www.vrplumber.com
  http://blog.vrplumber.com

Re: [PyOpenGL-Users] Code readability

[SAn <gri...@gm...>]

On Mon, May 23, 2011 at 16:34, Mike C. Fletcher <mcf...@vr...> wrote:
> On 11-05-21 11:47 AM, SAn wrote:
>> Hi! I am trying to understand pyopengl VBO implementation, well, the
>> whole OpenGL.array package.
>>
>> Is there a reason why the code is written so "anti-pep8/python zen"
>> way? Like that there isn't a new line between class methods, etc.
>> Maybe because of consistence with the automatic generator?
> Mostly because it is written by one crusty old pythonista who pre-dates
> PEP-8 (heck, PEPs entirely) by a significant period, and who looks at
> PEP-8 conformance as something those young whippersnappers do ;) :D .
> Be happy I finally gave in and started using spaces instead of tabs :)
> .  It took a plea directly from Pete Shinners (or maybe it was René?
> been a while) to get that to happen, and I felt dirty for months after.

> I'm fine with accepting a pep-8 patch, but keep in mind that APIs should
> not change, and I'm really not all that worried about keeping the
> code-base PEP-8-ified moving forward... that is, I can't guarantee I
> won't edit the files at some point and make them match my personal
> preference again :) .  If I start seeing people contributing code
> frequently I might revisit that opinion, but if it's still basically
> just me, I'll likely just do as comes naturally.

Ohh i see! I understand you.

I will be pep-8ing the code that have to read and eventually send you a patch.

Thanks for the reply!
SAn