Re: [Pyode-user] PyODE joint properties accessible as parameters

[Ethan Glasser-C. <gl...@cs...>]

al...@ci... wrote:
> Hello,
> 
> Here is the patch for accessing joint parameters as properties.

Sorry for the long delay. I have reviewed and applied this patch. A few
notes:

1. The old mechanism for setting parameters may have been faster because
the reference to the ODE function (dJointGetBallParam,
dJointSetBallParam) gets compiled away. But then again, it may be as
fast to just use function pointers, the way you do. Plus, your code is
cleaner.

2. Why set setJointParam and getJointParam per-instance rather than
making a class variable?

3. This is a big patch -- I would have been happier reviewing and
committing each change separately. For instance, moving to
setJointParam/getJointParam as one commit, then introducing the
parameters-as-properties thing, then introducing new joint types..

> I have tried to use 'Strip trailing spaces' in the editor, but now I have
> another problem.
> There are a lot of lines in the patch which do not change anything.
> e.g. (instead of dots, there are spaces):
> -....
> -      BallJoint(world, jointgroup=None)....
> +
> +      BallJoint(world, jointgroup=None)
> 

> How should I get rid of these? Manually editing the patch? Git Gui does not help me
> (i.e. 'Stage/Unstage hunk from commit' does not work properly, and messes the
> entire patch)

Normally I would commit a whitespace cleanup commit first, but it's
often hard to remember.. I have separated out the parts of your patch
that are whitespace fixes and applied these secondly. (I use magit,
which lets you stage/unstage individual lines.)

Ethan