Re: [Pyode-user] Kinematic state patch

[Ethan Glasser-C. <gl...@cs...>]

al...@ci... wrote:
> Hello,
> 
> I have patched PyODE by adding the following functions, which set the kinematic
> state of a rigid body:
> 
> body.setKinematic()
> body.setDynamic()
> body.isKinematic()
> 
> The functions are described here:
> http://opende.sourceforge.net/wiki/index.php/Manual_%28Rigid_Body_Functions
> %29#Kinematic_State

This is very cool. I've reviewed the patch. Some suggestions, if I may:

1. Don't send patches with trailing whitespace.
2. Send patches that apply from the root of the project (i.e. do cvs
diff from outside of src).

I'd also suggest changing the API to setKinematic(True/False), or
setDynamism(DEFAULT/DYNAMIC/KINEMATIC), but I guess it is useful to have
similar APIs to ODE.

I've cleaned up the whitespace and rewritten one of the docstrings for
clarity, and committed the resulting patch. Thanks.

> I have also attached the same patch to the project tracker a few days ago
> (at https://sourceforge.net/tracker/?group_id=73553&atid=538152 ),
> but I'm not sure whether anyone noticed it.

As you guessed, I don't check the project tracker and I doubt anyone
else does either :)

Ethan