#166 unused variables need removed in pymol code

[Jack Howarth]

A number of unused variables are flagged by the clang compilers...

layer1/CGO.cpp:3855:55: warning: unused variable 'hasNormals' [-Wunused-variable]
    int pl = 0, plc = 0, idxpl = 0, vpl = 0, tot, sz, hasNormals = 0;
                                                      ^
layer1/PyMOLObject.cpp:1217:7: warning: unused variable 'a' [-Wunused-variable]
  int a;
      ^
layer2/CoordSet.cpp:1300:7: warning: unused variable 'i' [-Wunused-variable]
  int i;
      ^
layer2/CoordSet.cpp:1303:7: warning: unused variable 'ok' [-Wunused-variable]
  int ok = true;
      ^
layer2/CoordSet.cpp:1590:7: warning: unused variable 'nAtom' [-Wunused-variable]
  int nAtom;
      ^
layer2/ObjectMolecule.cpp:4920:7: warning: unused variable 'a' [-Wunused-variable]
  int a;
      ^
layer2/ObjectMolecule.cpp:8529:10: warning: unused variable 'c' [-Wunused-variable]
  int a, c, cnt, atm, chg;
         ^
layer2/ObjectMolecule.cpp:8540:17: warning: unused variable 'ovresult' [-Wunused-variable]
  OVreturn_word ovresult;
                ^
layer2/ObjectMolecule.cpp:8890:10: warning: unused variable 'c' [-Wunused-variable]
  int a, c;
         ^
layer2/ObjectMolecule.cpp:11860:9: warning: unused variable 'b' [-Wunused-variable]
    int b;
        ^
layer3/Executive.cpp:13974:17: warning: unused variable 'I' [-Wunused-variable]
    CExecutive *I = G->Executive;
                ^
contrib/uiuc/plugins/molfile_plugin/src/jsplugin.c:403:16: warning: unused variable 'bszmask' [-Wunused-variable]
    fio_size_t bszmask;
               ^
contrib/uiuc/plugins/molfile_plugin/src/moldenplugin.c:828:7: warning: unused variable 's_expon' [-Wunused-variable]
        char s_expon[128], s_coeff1[128], s_coeff2[128];
             ^
contrib/uiuc/plugins/molfile_plugin/src/moldenplugin.c:828:21: warning: unused variable 's_coeff1' [-Wunused-variable]
        char s_expon[128], s_coeff1[128], s_coeff2[128];
                           ^
contrib/uiuc/plugins/molfile_plugin/src/moldenplugin.c:828:36: warning: unused variable 's_coeff2' [-Wunused-variable]
        char s_expon[128], s_coeff1[128], s_coeff2[128];
                                          ^
modules/cealign/src/tnt/tnt_matrix.h:549:15: warning: unused variable 'N' [-Wunused-variable]
    Subscript N = A.num_cols();
              ^
contrib/uiuc/plugins/molfile_plugin/src/edmplugin.cpp:207:10: warning: unused variable 'l' [-Wunused-variable]
  int z, l, sentinel, convcnt;
         ^
contrib/uiuc/plugins/molfile_plugin/src/edmplugin.cpp:220:7: warning: unused variable 'leftover' [-Wunused-variable]
  int leftover = (nperslice - (nlines - 1) * 6);
      ^
layer2/ObjectMolecule2.cpp:1933:10: warning: unused variable 'c' [-Wunused-variable]
  int a, c;
         ^
contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp:1883:9: warning: unused variable 'last_ctnumber' [-Wunused-variable]
    int last_ctnumber = -1;
        ^
contrib/uiuc/plugins/molfile_plugin/src/spiderplugin.cpp:277:7: warning: unused variable 'x' [-Wunused-variable]
  int x, y, z, xsize, ysize, zsize, xysize, total;
      ^
contrib/uiuc/plugins/molfile_plugin/src/spiderplugin.cpp:277:10: warning: unused variable 'y' [-Wunused-variable]
  int x, y, z, xsize, ysize, zsize, xysize, total;
         ^
contrib/uiuc/plugins/molfile_plugin/src/spiderplugin.cpp:277:13: warning: unused variable 'z' [-Wunused-variable]
  int x, y, z, xsize, ysize, zsize, xysize, total;
            ^
contrib/uiuc/plugins/molfile_plugin/src/mdfplugin.cpp:135:7: warning: unused variable 'retval' [-Wunused-variable]
  int retval;
      ^
contrib/uiuc/plugins/molfile_plugin/src/mmcif.cpp:85:14: warning: unused variable 'data' [-Wunused-variable]
  mmcifdata *data = (mmcifdata *)mydata;
             ^

The attached patch eliminates these warnings.

[Thomas Holder]

partly applied in svn rev 4115. Files from third-party libraries untouched (contrib, tnt).